1832459 - Remove or update metrics expiring in Firefox 116: rtcrtpsender.*

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Description

[telemetry-probes]

The following metrics will expire in the next Firefox Nightly release: version 1161.

rtcrtpsender.count
rtcrtpsender.count_setparameters_compat
rtcrtpsender.setparameters.fail_length_changed
rtcrtpsender.setparameters.fail_no_encodings
rtcrtpsender.setparameters.fail_no_getparameters
rtcrtpsender.setparameters.fail_no_transactionid
rtcrtpsender.setparameters.fail_other
rtcrtpsender.setparameters.fail_rid_changed
rtcrtpsender.setparameters.fail_stale_transactionid
rtcrtpsender.setparameters.warn_length_changed
rtcrtpsender.setparameters.warn_no_getparameters
rtcrtpsender.setparameters.warn_no_transactionid
rtcrtpsender.setparameters.warn_rid_changed
rtcrtpsender.setparameters.warn_stale_transactionid
rtcrtpsender.used_sendencodings

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their metrics.yaml definition file.
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review 2 and patch to extend their expiry. There is a shorter form for data collection renewal 3.

If you have any problems, please ask for help on the #glean Matrix room or the #data-help Slack channel.
We'll give you a hand.

Your Friendly Neighbourhood Glean Team

---

This bug was auto-filed by probe-scraper.

Comment 1

[Byron Campen [:bwc]]

We'll need to renew these, sadly. Probably bump them to 120, to match the blame_* versions introduced in bug 1831343.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=fa86ce10e34d2298b75529273c96a2ae7f6ba667

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1832459: Extend the expiry for (most of) these metrics to 120. r?chutten

We are not renewing warn_rid_changed, because we are no longer recording it.

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 9333139 [details]
Bug 1832459: Extend the expiry for (most of) these metrics to 120. r?chutten

Provide a link to the initial Data Collection Review Request for this collection.
https://bugzilla.mozilla.org/show_bug.cgi?id=1401592#c30

When will this collection now expire?
120

Why was the initial period of collection insufficient?
Because webrtc sites aren't fixing their code :(

Comment 5

[Chris H-C :chutten]

Attachment: data collection renewal request

Comment 6

[Chris H-C :chutten]

Comment on attachment 9333150 [details]
data collection renewal request

DATA REVIEW RESPONSE:

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---

Result: datareview+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b6a8450c0ea
Extend the expiry for (most of) these metrics to 120. r=chutten,jib

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8b6a8450c0ea

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

warn_rid_changed needs to be taken care off (expiring with the bump to version 116): https://hg.mozilla.org/mozilla-central/file/8b6a8450c0ea3cf121fe0c788ddb349daff4f6bf/dom/media/webrtc/metrics.yaml#l139
dom/media/webrtc/tests/mochitests/test_peerConnection_glean.html will fail because it uses this measurement.

Comment 10

[Byron Campen [:bwc]]

We need to just remove that test, since we're letting it expire.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1832459 - temporarily disable test_peerConnection_glean.html. r=bwc

Test has checks which depend on telemetry probe for warn_rid_changed which
expired with Gecko version increase to 116.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1f1056adf690
temporarily disable test_peerConnection_glean.html. r=bwc a=fix-perma-fail

Comment 14

[Intermittent Failures Robot]

21 failures in 776 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 18
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64: 17
  • opt: 17
• windows11-64: 2
  • opt: 2
• macosx1015-64: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1832459&startday=2023-06-20&endday=2023-06-20&tree=all

Comment 15

[Nico Grunbaum [:ng, @chew:mozilla.org]]

bwc thinks the test cases need a minor tweak. Bouncing the ni back to him for now.

Comment 16

[Intermittent Failures Robot]

23 failures in 3880 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 20
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64: 18
  • opt: 18
• windows11-64: 3
  • opt: 3
• macosx1015-64: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1832459&startday=2023-06-19&endday=2023-06-25&tree=all

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Could this be fixed this week (= before the merge next week)?

Comment 18

[Byron Campen [:bwc]]

I'm back, and on it.

Comment 19

[Byron Campen [:bwc]]

Attachment: Bug 1832459: Remove test-cases for the no-longer-supported warn_rid_changed. r?ng

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d01de27a80e
Remove test-cases for the no-longer-supported warn_rid_changed. r=ng

Comment 21

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3d01de27a80e

Comment 22

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Probe also needs removal, will submit a patch.

Comment 23

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1832459 - remove now unused rtcrtosender.setparameters.warn_rid_changed probe. r=bwc

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee32af33954
remove now unused rtcrtosender.setparameters.warn_rid_changed probe. r=bwc

Comment 25

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8ee32af33954

Comment 26

[Intermittent Failures Robot]

6 failures in 3594 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6

Platform and build breakdown:

• macosx1015-64: 2
  • opt: 2
• linux1804-64: 3
  • opt: 3
• windows11-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1832459&startday=2023-06-26&endday=2023-07-02&tree=all