Avoid libXtst dependency?
Categories
(Core :: WebRTC, task)
Tracking
()
People
(Reporter: glandium, Assigned: mjf)
Details
Attachments
(3 files)
I was looking at our requirements on the Firefox system requirements page, and we have a requirement for libXtst, and while looking possibly what version we might be actually requiring (to validate that the requirements page is good) I ... found no symbols used from the library.
It turns out there's only one place that uses the library: SharedXDisplay::IgnoreXServerGrabs. And the function is used nowhere, so in release builds, it's garbage collected and nothing uses XTest* symbols... while we do still link the library, which becomes a hard requirement.
It would be great if we could remove this dependency.
Reporter | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
This should be easy enough to do. I'll get started on it.
Assignee | ||
Comment 2•1 year ago
|
||
Assignee | ||
Comment 3•1 year ago
|
||
Depends on D189386
Comment 5•1 year ago
|
||
We can remove this from the system requirements after merging to m-c.
Comment 6•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0ec1b33b95db
https://hg.mozilla.org/mozilla-central/rev/d5f682818642
Reporter | ||
Comment 7•1 year ago
|
||
The build still has a Xtst dependency because of https://searchfox.org/mozilla-central/rev/b0d28aecd58cbd2db00974db2ef8456856169fb4/toolkit/moz.configure#1410
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
I've never run across that file before. I'll add another patch to remove the reference.
Assignee | ||
Comment 9•1 year ago
|
||
Comment 10•1 year ago
|
||
Comment 11•1 year ago
|
||
bugherder |
Comment 12•1 year ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
We can remove this from the system requirements after merging to m-c.
Removed (- libxtst 1.2.3 or higher) from the Nightly Fx120 release notes System requirements
https://www.mozilla.org/en-US/firefox/120.0a1/releasenotes/
Description
•