1832465 - Avoid libXtst dependency?

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Mike Hommey [:glandium]]

I was looking at our requirements on the Firefox system requirements page, and we have a requirement for libXtst, and while looking possibly what version we might be actually requiring (to validate that the requirements page is good) I ... found no symbols used from the library.

It turns out there's only one place that uses the library: SharedXDisplay::IgnoreXServerGrabs. And the function is used nowhere, so in release builds, it's garbage collected and nothing uses XTest* symbols... while we do still link the library, which becomes a hard requirement.

It would be great if we could remove this dependency.

Comment 1

[Michael Froman [:mjf]]

This should be easy enough to do. I'll get started on it.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1832465 - remove libXtst usage from libwebrtc. r?ng!

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1832465 - remove libXtst usage from libwebrtc - moz.build file updates. r?ng!

Depends on D189386

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ec1b33b95db
remove libXtst usage from libwebrtc. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/d5f682818642
remove libXtst usage from libwebrtc - moz.build file updates. r=ng,webrtc-reviewers

Comment 5

[Ryan VanderMeulen [:RyanVM]]

We can remove this from the system requirements after merging to m-c.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0ec1b33b95db
https://hg.mozilla.org/mozilla-central/rev/d5f682818642

Comment 7

[Mike Hommey [:glandium]]

The build still has a Xtst dependency because of https://searchfox.org/mozilla-central/rev/b0d28aecd58cbd2db00974db2ef8456856169fb4/toolkit/moz.configure#1410

Comment 8

[Michael Froman [:mjf]]

I've never run across that file before. I'll add another patch to remove the reference.

Comment 9

[Michael Froman [:mjf]]

Attachment: Bug 1832465 - remove xtst lib reference from toolkit/moz.configure r?glandium!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a120317e670a
remove xtst lib reference from toolkit/moz.configure r=glandium

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a120317e670a

Comment 12

[Dianna Smith [:diannaS]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

We can remove this from the system requirements after merging to m-c.

Removed (- libxtst 1.2.3 or higher) from the Nightly Fx120 release notes System requirements
https://www.mozilla.org/en-US/firefox/120.0a1/releasenotes/