Closed Bug 1832490 Opened 2 years ago Closed 1 years ago

use `addLoginAsync` instead of `addLogin` in LoginManagerAuthPrompter.promptUsernameAndPassword and LoginManagerAuthPrompter.promptPassword

Categories

(Toolkit :: Password Manager, task)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: joschmidt, Assigned: joschmidt)

References

(Depends on 2 open bugs)

Details

(Whiteboard: [fxcm-tech-debt])

Attachments

(1 file)

in toolkit/components/passwordmgr/LoginManagerAuthPrompter.sys.mjs

Depends on: 1832493
Depends on: 1832495
Depends on: 1832756
Depends on: 1832757

to use addLoginAsync instead of addLogin.

Assignee: nobody → joschmidt
Status: NEW → ASSIGNED
Pushed by joschmidt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05a4a11191f0 make LoginManagerAuthPrompter promts async r=credential-management-reviewers,necko-reviewers,jesup,dimi
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Regressions: 1834406
Regressions: 1841348
Regressions: 1841491

This change requires major refactoring in many areas ion Thunderbird, in a time when we were trying to finalize the yearly release.

Would you see any way to keep the old sync APIs in place for the ESR 115 version, and postpone the change to 116 or later?

The impact to TB might be smaller than I had anticipated, which might explain why we didn't see failures earliers.

Regressions: 1841690
See Also: → 1841690
See Also: 1841690
No longer regressions: 1841690
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: