1832532 - GitHub builds unable to parse user.js settings files

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P1)

Description

[James Graham [:jgraham]]

Bug 1830265 introduced a backwards-incompatible change into the format of user.js files used to store testing prefs. It also updated mozprofile to allow reading the updated format.

Unfortunately these files are not only used in-tree but also in upstream web-platform-tests. This is currently breaking all the upstream builds (see e.g. this log) and is therefore preventing results being updated on wpt.fyi or on the interop 2023 Dashboard. This is an important public metric that we're tracking, so we need a quick resolution to this problem.

Unfortunately this external usage isn't covered by CI, and it's not expected that everyone understands the details of out-of-tree uses of the code, so the problem was hard to detect before landing.

AFAICT there are two options:

• We back out the original changeset
• We do an urgent mozprofile release, so that external tools can get the new code version.

Ideally we'd backout the user.js changes to provide an immediate fix, then release a new mozprofile version, and finally reland the user.js changes once the external systems have a chance to update. That would mean the problem would be fixed as soon as the initial backout reaches central, rather than needing to wait for the mozprofile update to roll out.

Comment 1

[Mark Banner (:standard8)]

Is it just testing/profiles/web-platform/user.js causing the issues, or do the other user.js files do as well? I guess testing/profiles/common/user.js might be another one?

If that's the case, I would propose that we undo the changes to those, and add them to .prettierignore temporarily. Once the dashboard is updated, then we can undo the change.

Comment 2

[James Graham [:jgraham]]

Everything in https://searchfox.org/mozilla-central/source/testing/profiles/profiles.json#34-40 is used in (some configurations of) web-platform-tests, so I'm not sure there's much advantage in trying to revert specific files vs the entire changeset outside of testing/mozbase.

Comment 3

[Mark Banner (:standard8)]

Ok yeah, everything outside of testing/mozbase/ seems fine then. If I create the backout patch, can you file a bug for the mozprofile update? (I assume that'll need its own bug).

Does the backout also need to go onto 114?

Comment 4

[James Graham [:jgraham]]

You we are using branches for the non-central builds, so if we can uplift the backout that would be appreciated.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1832532 - Undo prettier formatting changes to testing/profiles/**/user.js until mozprofile is updated. r?jgraham!.

.prettierignore is not updated here, as unfortunately the exclusion for these files slipped back in during other patches.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1830265

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c65ccc2a49bb
Undo prettier formatting changes to testing/profiles/**/user.js until mozprofile is updated. r=jgraham,perftest-reviewers,sparky.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 9333056 [details]
Bug 1832532 - Undo prettier formatting changes to testing/profiles/**/user.js until mozprofile is updated. r?jgraham!.

Beta/Release Uplift Approval Request

• User impact if declined: None - This helps to fix the web platform test dashboard.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky as this only reverts a formatting change to some test files.
• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c65ccc2a49bb

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9333056 [details]
Bug 1832532 - Undo prettier formatting changes to testing/profiles/**/user.js until mozprofile is updated. r?jgraham!.

Approved for 114 beta 4, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7a3d7ed6b753

Comment 12

[Mark Banner (:standard8)]

Attachment: Bug 1832532 - Re-add testing/profiles/**/user.js Prettier exception for beta.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/443487bfed74