1832567 - (really) Clear breakpoints reducer on each target/thread removal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1814177, the breakpoints reducer already tries to clear itself on thread removal, unfortunately this code doesn't work because source.thread is no longer defined since we moved to breakpoint per URL.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1832567 - [devtools] Clear breakpoints correctly on thread removal.

Unfortunately, breakpoints aren't bound to a particular thread.
Instead they are bound to the source were the breakpoint is set.
Also sources aren't bound to a particular thread, this is especially true
when we are against an original source which may be used in distinct threads.

So let's use the sources list dispatched on REMOVE_THREAD to identify
the breakpoint to remove when a thread is removed.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1832567 - [devtools] Stop using source.thread which no longer exists.

This attribute has been removed since we moved to breakpoints per URL.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1832567 - [devtools] Avoid using await for synchronous actions.

Actions are dispatched synchronously by default, unless we dispatch an thunk action,
which may be asynchronous (but not always); or for action using "promise" attribute
which is made asynchronous by a middleware.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75e719602096
[devtools] Clear breakpoints correctly on thread removal. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/14df400dba55
[devtools] Stop using source.thread which no longer exists. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/21cb9d7c0aa8
[devtools] Avoid using await for synchronous actions. r=devtools-reviewers,bomsy

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/75e719602096
https://hg.mozilla.org/mozilla-central/rev/14df400dba55
https://hg.mozilla.org/mozilla-central/rev/21cb9d7c0aa8