1832624 - Remove original observeAsComposableState

Status: NEW

(Firefox for Android :: General, enhancement, P3)

Description

[Matt Tighe [:matt-tighe]]

With the introduction of the non-nullable observeAsComposableState in this patch, we could potentially remove the old nullable version to clean up a lot of unnecessary null guarding.

1. Check whether all usages can safely provide a initial value (from a store or otherwise)
2. Refactor all old fun <S : State, A : Action, R> Store<S, A>.observeAsComposableState(map: (S) -> R): ComposeState<R?> usages to the new signature:

@Composable
fun <S : State, A : Action, R> Store<S, A>.observeAsComposableState(
    initialValue: R,
    map: (S) -> R,
): ComposeState<R> { 

Comment 1

[Matt Tighe [:matt-tighe]]

It's also worth considering the impact this would have on other A-C consumers.