1832710 - Shift+Ctrl+V in Slack's message editor pastes two copies of the clipboard text (also Gmail, Google Calendar & Chat, etc)

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Masayuki, this bug is a regression from your fix for bug 1815969. I bisected this regression to this pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e5722e588dfcf4b62e3d34ea5b96139d10c0453&tochange=55c1f2ce765b4df00a8b676bda791f0fcfa0ad90

Steps to reproduce

1. Open Slack in Firefox 115.
2. Copy some text to your clipboard, such as the word test.
3. Focus Slack's message editor.
4. Shift+Ctrl+V to paste the clipboard text. Shift+Ctrl+V is a keyboard short that commonly pastes clipboard text without any rich text formatting that may have been copied.

Expected behavior

test

In Firefox 114 and Chrome, Shift+Ctrl+V pastes the clipboard text. In Safari, Shift+Ctrl+V doesn't paste anything, which seems like a different bug.

Actual behavior

testtest

In Firefox 115, Shift+Ctrl+V pastes two copies of the clipboard text.

Comment 1

[Chris Peterson [:cpeterson]]

I can reproduce this bug on Windows and macOS. I haven't tested Linux.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

Thank you for catching the regression! Taking a look...

Comment 3

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

I can reproduce this same issue on various Google products, specifically for textareas that support text formatting, like:

• Google chat
• Gmail compose view (the message body area)
• Google Calendar, event description field (not the event title field)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Happens in Slack too.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

Attachment: Bug 1832710 - Make `EditorBase::DispatchClipboardEventAndUpdateClipboard` handle `ePasteNoFormatting` event message r=m_kato!

Just a mistake, it should treat ePasteNoFormatting as an equivalent of ePaste.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7176a7cccb3f
Make `EditorBase::DispatchClipboardEventAndUpdateClipboard` handle `ePasteNoFormatting` event message r=m_kato

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7176a7cccb3f

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-11 Nightly build on macOS 12 on Slack.
Verified as fixed on Firefox 115.0b4(build ID: 20230611180300) and Nightly 116.0a1(build ID: 20230612211509) on macOS 12, Windows 10, Ubuntu 22, on Slack.
Shift + CTRL/CMD + C now pastes only one copy of the clipboard text.