1832791 - Implement a Remote Settings for the Quarantined Domains pref

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Tomislav Jovanovic :zombie]

We need to have ability to set the list of quarantined domains remotely. The pref should be a string with the same format as extensions.webextensions.restrictedDomains.

The pref will be extensions.webextensions.quarantinedDomains, and it will have a default value set in a patch for bug 1745823 (to include a couple real but "test" subdomains from badssl.com).

Filing as confidential for now, until we ship the system addon.

Comment 1

[Andrew McCreight [:mccr8]]

Should these bugs be MoCo confidential instead? If not please mark them sec-other or something so they don't show up in triage. Thanks.

Comment 2

[Tomislav Jovanovic :zombie]

Yeah we were discussing exactly this, as the confidential checkbox says "non-security", and this is security related (though not a bug).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1832791 - Add to AMRemoteSettings support for quarantinedDomains RemoteSettings entries. r?robwu!,zombie

This patch introduce a small set of changes applied on AMRemoteSettings to:

• support RS collection entries that are going to set prefs of type string
• support setting prefs that match a given preference name prefix
• support for a new RS collection entry property named quarantinedDomains, from which AMRemoteSettings
  will pick up any preference name prefixed as "extensions.webextensions.quarantinedDomains."

Along with the changes on the AMRemoteSettings side, this patch include also the changes to the
JSONSchema associated to the "addon-manager-settings" collection on the RemoteSettings server side
(to include a new property and definition for quarantinedDomains, and a patternProperties which
enforces the preference name convention and expected value type for all quarantinedDomains properties).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/969ddbe64bb0