1833063 - Commonalize similar/same codes for Addon and Weather suggestions

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Daisuke Akatsuka (:daisuke)]

This is a follow-up bug for bug 1832474.
As was pointed out in phabricator, as there are some similar/same codes in Addon and Weather suggestions, communalize them.

• https://phabricator.services.mozilla.com/D177852#inline-984589
• https://phabricator.services.mozilla.com/D177852#inline-984590

Comment 1

[Marco Bonardo [:mak]]

Drew, I remember you recently made improvements to this code to share more parts. Is this something we should do yet?

Comment 2

[Drew Willcoxon :adw]

Yes, there's still some consolidation we can do. The things Daisuke mentioned are still relevant; here's a quick list of things we can do at any time:

1. Consolidate definitions of command names used in the various Suggest features. For example "not_interested" is defined in many places.
2. If it makes sense, consolidate the implementation of getResultCommands() in the Suggest features (and weather provider). They aren't exactly the same so it might not be worth trying to factor that out.
3. Consolidate browser test code for testing result menu commands. All the Suggest features have similar browser test code for this: For each result menu command, they open the result menu, click an item, and make sure it did the right thing. In addition to that basic commonality, some commands themselves are the same across features. See the relevant files in https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/quicksuggest/browser/