1833207 - Load dmabuf modifiers from off main thread

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[C.M.Chang[:chunmin]]

DMABufDevice::LoadFormatModifiers() requires to be called on main thread , which implicitly implies FFmpegVideoDecoder::Init() needs to be run on the main thread as well since DMABufDevice::LoadFormatModifiers() will be called via the following path:

1. FFmpegVideoDecoder::Init()
2. FFmpegVideoDecoder::InitVAAPIDecoder() // MOZ_WAYLAND_USE_VAAPI
3. FFmpegVideoDecoder::CreateVAAPIDeviceContext()
4. widget::GetDMABufDevice()
5. widget::DMABufDevice::Configure()
6. widget::DMABufDevice::LoadFormatModifiers()

However, FFmpegVideoDecoder::Init() can be called on a non-main thread in some cases. For example, in WebCodecs, the media decoder is going to be exposed to both the main thread and the worker thread. This means either MediaDataDecoder works on the main thread or worker thread, or MediaDataDecoder works in a dedicated task queue (off-main thread) that is operated by the main thread and worker thread, depending on the implementation of VideoDecoder interface.

Comment 1

[C.M.Chang[:chunmin]]

Hey :stransky, do you have idea how to make DMABufDevice::LoadFormatModifiers() work off main thread?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1830162

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to C.M.Chang[:chunmin] from comment #1)

Hey :stransky, do you have idea how to make DMABufDevice::LoadFormatModifiers() work off main thread?

Yes, will look at it. We need to run it on main thread on parent process only where dmabuf modifiers are loaded from wayland compositor.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1833207 [Wayland] Request to load dmabuf modifiers on main thread for parent process only r?emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9345307f5a06
[Wayland] Request to load dmabuf modifiers on main thread for parent process only r=emilio

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9345307f5a06