1833272 - Navigation to templated method is still tripped up by use of this->

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Botond Ballo [:botond]]

Steps to reproduce

Have Searchfox index the following code:

template <typename> struct Point {};

template <typename T>
struct Foo {
  template <typename F>
  void Project(Point<F>) {}

  void Bar() {
    Point<T> tp;
    this->Project(tp);
  }
};

Expected results

Navigation from the call to Project() goes to the definition.

Actual results

No navigation is offered at the call.

Comment 1

[Botond Ballo [:botond]]

The this-> changes the expression type from UnresolvedMemberExpr (which is a subclass of OverloadExpr) to CXXDependentScopeMemberExpr, and since the target is a function template, HeuristicResolver::resolveMemberExpr() gives us a FunctionTemplateDecl, which is not a FunctionDecl. We need to unwrap the TemplateDecl the way we do in VisitOverloadExpr().

Comment 2

[Botond Ballo [:botond]]

mozsearch repo PR: https://github.com/mozsearch/mozsearch/pull/630/

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1833272 - Handle templated heuristic results in VisitCXXDependentScopeMemberExpr. r=asuth

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da27ccc7c99a
Handle templated heuristic results in VisitCXXDependentScopeMemberExpr. r=asuth DONTBUILD

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/da27ccc7c99a