1833368 - [wpt-sync] Sync PR 40029 - webrtc wpt: prefer SDP parsing utils over regexp

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40029 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40029
Details from upstream follow.

Philipp Hancke <[e-mail]> wrote:

webrtc wpt: prefer SDP parsing utils over regexp

BUG=None

Change-Id: I233b3184178cac1ce92ea8b24b9d619b54aa19b9
Reviewed-on: https://chromium-review.googlesource.com/4537801
WPT-Export-Revision: 85d9c76248abb963087a850efa2584345d44e287

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=64a50c1b9dea549df49baf2d1d90749fa8d792c7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=582871bb1e9cd2fccd54a32666787d68323c578c

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 5 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 18 subtests

Status Summary

Firefox

OK : 9[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 12[GitHub]
PASS : 38[GitHub] 41[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt]
FAIL : 20[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 26[GitHub]

Chrome

OK : 11
PASS : 21
FAIL : 42
TIMEOUT: 2

Safari

OK : 7
PASS : 15
CRASH : 2
FAIL : 30
TIMEOUT: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /webrtc/simulcast/getStats.https.html [wpt.fyi]
  • Simulcast getStats results: FAIL linked bug:Bug 1643001
• /webrtc/simulcast/h264.https.html [wpt.fyi]
  • H264 simulcast setup with two streams: FAIL
• /webrtc/simulcast/vp8.https.html [wpt.fyi]
  • VP8 simulcast setup with two streams: FAIL

New Tests That Don't Pass

• /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
  • Simulcast getStats results: FAIL (Chrome: PASS, Safari: PASS)
• /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: CRASH)
  • Remote reanswer altering rids does not throw an exception.: FAIL (Chrome: PASS)
• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
  • Basic simulcast setup with three spatial layers: FAIL (Chrome: PASS, Safari: FAIL)
• /webrtc/simulcast/h264.https.html [wpt.fyi]
  • H264 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
• /webrtc/simulcast/setParameters-encodings.https.html [wpt.fyi]
  • Success task for setLocalDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
  • Success task for setRemoteDescription(offer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
  • Success task for setRemoteDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
• /webrtc/simulcast/vp8.https.html [wpt.fyi]
  • VP8 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
• /webrtc/simulcast/vp9-scalability-mode.https.html [wpt.fyi]
  • VP9 simulcast setup with two streams and L1T2 set: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /webrtc/simulcast/vp9.https.html [wpt.fyi]
  • VP9 simulcast setup with two streams: FAIL (Chrome: TIMEOUT, Safari: TIMEOUT)
• /webrtc-extensions/RTCRtpParameters-codec.html [wpt.fyi]
  • Creating an audio sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a video sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting codec on an audio sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting codec on a video sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating an audio sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a video sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-existing codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-existing codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-preferred codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-preferred codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-negotiated codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Setting a non-negotiated codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
  • Codec should be undefined after negotiating away the currently set codec on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Codec should be undefined after negotiating away the currently set codec on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Stats output-rtp should match the selected codec in non-simulcast usecase on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
  • Stats output-rtp should match the selected codec in non-simulcast usecase on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
• /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: CRASH)
• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601368d6fe8f
[wpt PR 40029] - webrtc wpt: prefer SDP parsing utils over regexp, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/601368d6fe8f