183337 - build fails as fontconfig.h is not included

Status: VERIFIED DUPLICATE of bug 178128

(SeaMonkey :: Build Config, defect)

Description

[Sam Halliday]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.0.1) Gecko/20021103
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.0.1) Gecko/20021103

the file "gfx/src/gtk/nsFontMetricsXft.h"

is missing a necessary
#include <fontconfig/fontconfig.h>

and the build will fail without it. (on my system anyway)

Reproducible: Always

Steps to Reproduce:
a build from source with these options (although, should fail on any setup)

export MOZILLA_OFFICIAL=1
export BUILD_OFFICIAL=1
export MOZ_INTERNAL_LIBART_LGPL=1
echo mk_add_options MOZ_INTERNAL_LIBART_LGPL=1 >> .mozconfig
echo ac_add_options --prefix=$GNOME_ROOT >> .mozconfig
echo ac_add_options --with-pthreads >> .mozconfig
echo ac_add_options --with-system-jpeg >> .mozconfig
echo ac_add_options --with-system-zlib >> .mozconfig
echo ac_add_options --with-system-png >> .mozconfig
echo ac_add_options --with-system-mng >> .mozconfig
echo ac_add_options --enable-crypto >> .mozconfig
echo ac_add_options --disable-jsd >> .mozconfig
echo ac_add_options --disable-accessibility >> .mozconfig
echo ac_add_options --enable-mathml >> .mozconfig
echo ac_add_options --enable-svg >> .mozconfig
echo ac_add_options --disable-tests >> .mozconfig
echo ac_add_options --disable-debug >> .mozconfig
echo ac_add_options --disable-dtd-debug >> .mozconfig
echo ac_add_options --enable-reorder >> .mozconfig
echo ac_add_options --enable-strip >> .mozconfig
echo ac_add_options --enable-elf-dynstr-gc >> .mozconfig
echo ac_add_options --enable-cpp-rtti >> .mozconfig
echo ac_add_options --disable-mailnews >> .mozconfig
echo ac_add_options --disable-ldap >> .mozconfig
echo ac_add_options --enable-xft >> .mozconfig
echo ac_add_options --disable-logging >> .mozconfig
echo ac_add_options --enable-plaintext-editor-only >> .mozconfig
echo ac_add_options --enable-extensions="default,-venkman,-inspector,-irc" >>
.mozconfig
echo ac_add_options --enable-old-abi-compat-wrappers >> .mozconfig
./configure
make
Actual Results:  
make error

Expected Results:  
make the object file

bugzilla asks for too much! :D

Comment 1

[Matthias Versen [:Matti]]

-> Build Config (or int ?)

Comment 2

[hacker formerly known as [e-mail]]

Sounds like a conflict in the way fontconfig was installed.  Over to blizzard.

Comment 3

[Christopher Blizzard (:blizzard)]

Sounds like you're trying to build with Xft 1 which does not work.  You need Xft2.

*** This bug has been marked as a duplicate of 178128 ***

Comment 4

[Sam Halliday]

no,

i am building with Xft-2.1, i have attached my build and install instructions to
install to /opt/gnome as the choosen location. has mozilla not been upgraded to
2.1 yet? in that case i will downgrade.

cheers,
Sam

go to http://fontconfig.org
get http://fontconfig.org/release/fcpackage.2_1.tar.gz
do this (a lot of my machine specific include dirs)

tar xfz fcpackage.2_1.tar.bz2
cd fcpackage.2_1/fontconfig
# here use the expat libs from apache, but you can build it separatly also
CC="$CC -I/opt/apache/include -L/opt/apache/lib" ./configure \
     --prefix=$GNOME_ROOT --disable-debug --disable-nls
make CC="$CC -I/opt/apache/include -L/opt/apache/lib"
make install
ldconfig
cd ../Xft1
xmkmf
make CC="$CC -I/opt/gnome/include -L/opt/gnome/lib" \
   FREETYPE2INCLUDES="-I/usr/X11R6/include/freetype2" DESTDIR="/opt/gnome"
make CC="$CC -I/opt/gnome/include -L/opt/gnome/lib" \
   FREETYPE2INCLUDES="-I/usr/X11R6/include/freetype2" DESTDIR="/opt/gnome" install
ldconfig
cd ../Xft
./configure --prefix=$GNOME_ROOT --disable-debug --disable-nls
make CC="$CC -I/opt/gnome/include -L/opt/gnome/lib "
make install
ldconfig
cd ../..
rm -rf fcpackage.2_1

Comment 5

[Christopher Blizzard (:blizzard)]

What does xft.pc live?  Does it contain the proper paths to the fontconfig headers?

[blizzard@dead mozilla]$ pkg-config --cflags xft
 -I/usr/include/Xft2 -I/usr/include/freetype2 -I/usr/X11R6/include  

On my system fontconfig is installed in the system path, it doesn't need any
special includes.

Comment 6

[Sam Halliday]

it lives in /opt/gnome/lib/pkgconfig, which pkg-config can see clearly as is
demonstrated by...

pkg-config --cflags xft
-I/opt/gnome/include -I/usr/X11R6/include/freetype2 -I/usr/X11R6/include  

here is the actual xft.pc (although the maintainers obviously have not bumped up
the version number as i am using 2.1 from the website)

####################
prefix=/opt/gnome
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
freetypelibs=-L/usr/X11R6/lib -lfreetype
freetypecflags=-I/usr/X11R6/include/freetype2
xrenderlibs=-L/usr/X11R6/lib -lXrender
xrendercflags=-I/usr/X11R6/include

Name: Xft
Description: X FreeType library
Version: 2.0.0
Requires: fontconfig
Libs: -L${libdir} -lXft ${freetypelibs} ${xrenderlibs}
Cflags: -I${includedir} ${freetypecflags} ${xrendercflags}
####################

thanks again!
Sam
PS: i have XFree-4.2.1, the website says that Xft-2 is part of XFree now, should
my X build not have installed this without me having to do it seperately? it
obviously installs libXft.so.1 by default, but that is a different library... ok
this question is best directed to the XFree team adn i will ask there instead
since this is not a forum for discussion...

Comment 7

[Sam Halliday]

i found the problem is the same as #3 from Neil Weisenfeld of bug 178128, i will
mark this as a duplicate now.

however, comment #4 from Christopher Blizzard
"OK, so it's a problem with the include files on your system then."
is an incorrect diagnosis... it is the mozilla config scripts which are to blame
as they should always place the fontconfig/Xft2 includes before the X11R6 ones
(if they are different locations)

cheers,
Sam

Comment 8

[Sam Halliday]

*** This bug has been marked as a duplicate of 178128 ***

Comment 9

[Tracy Walker [:tracy]]

verified