1833441 - If revision->uplift_request is empty, format_uplift_request_as_markdown still tries to generate a comment causing hash error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

Revision.pm has uplift_request set to Maybe which means it can in some cases be empty. So we need to check for that in the code.

{"Hostname":"gha-bugzilla-phabbugz-7dc75d7499-skdnc","Severity":6,"Timestamp":1684256001000000000,"Fields":{"msg":"STORY TEXT: issammani updated the uplift request field for D178189: Bug 1831833 - Import modules lazily where possible..","type":"FEED"},"Pid":7,"EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Logger":"STDERR"}
{"Hostname":"gha-bugzilla-phabbugz-7dc75d7499-skdnc","Logger":"STDERR","Type":"Bugzilla.Extension.PhabBugz.Feed","EnvVersion":2.0,"Pid":7,"Fields":{"type":"FEED","msg":"REVISION CHANGE FOUND: D178189: Bug 1831833 - Import modules lazily where possible. | bug: 1831833 | issammani | issammani updated the uplift request field for D178189: Bug 1831833 - Import modules lazily where possible.."},"Timestamp":1684256001000000000,"Severity":6}
{"Logger":"STDERR","EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Pid":7,"Timestamp":1684256001000000000,"Fields":{"msg":"Commenting the uplift form on the bug.","type":"FEED"},"Severity":6,"Hostname":"gha-bugzilla-phabbugz-7dc75d7499-skdnc"}
{"Hostname":"gha-bugzilla-phabbugz-7dc75d7499-skdnc","Logger":"STDERR","Pid":7,"EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1684256001000000000,"Fields":{"msg":"Not a HASH reference at /app/extensions/PhabBugz/lib/Feed.pm line 384.\n"},"Severity":0}

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1833441 - If revision->uplift_request is empty, format_uplift_request_as_markdown still tries to generate a comment causing hash error (#2069)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/c5ffeb41ae7f5ca0cbb44bb0f9951e442739891c