1833520 - Allow setting new migration prefs from about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Experiment targeting Fx114 might need the ability to set certain prefs from about:welcome.

In order to support about:welcome experiments with treatment branches that use the new import experience without relying on Nimbus multifeature capability from bug 1726190 (to configure aboutwelcome screens and migrationWizard prefs still relying on server-side changes), we'll need to be able to configure the migration wizard to show the desired experience. E.g.,

             {
               id: "checkbox-2",
               defaultValue: true,
               label: {
                 string_id: "mr2022-onboarding-easy-setup-import-checkbox-label",
               },
               action: {
+                type: "MULTI_ACTION",
+                data: {
+                  actions: [
+                    {
+                      type: "SET_PREF",
+                      data: {
+                        pref: {
+                          name:
+                            "browser.migrate.content-modal.about-welcome-behavior",
+                          value: "standalone",
+                        },
+                      },
+                    },
+                    {
                       type: "SHOW_MIGRATION_WIZARD",
                       data: {},
+                    },
+                  ],
+                },
               },
             },

Comment 1

[Ed Lee :Mardak]

Might want to clear prefs in case users go back a screen and uncheck as supported in bug 1823777. Although we might not have a good way to clean up pref changes for those who do enroll into the branch and does the action to set prefs.

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1833520 - Allow setting new migration prefs from about:welcome r?pdahiya,mconley

Include prefs needed to enable content modal as experimented in 113.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfed793865f8
Allow setting new migration prefs from about:welcome r=pdahiya

Comment 4

[Ed Lee :Mardak]

Comment on attachment 9334466 [details]
Bug 1833520 - Allow setting new migration prefs from about:welcome r?pdahiya,mconley

Beta/Release Uplift Approval Request

• User impact if declined: Users might not see the expected experiment experience
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes comment 6
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See Test Plan https://phabricator.services.mozilla.com/D178256
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Doesn't change default behavior and might only be used in 114 experiment that would go through experiment QA before launching
• String changes made/needed: none
• Is Android affected?: No

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cfed793865f8

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 115.0a1 (Build ID: 20230517153544) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• After following the testing steps from this Test Plan, I confirm the following:
  • The "content-modal" prefs are set (enabled=true, behavior=standalone, import-all=true) after clicking the primary button while the “Import from previous browser” checkbox is checked.
  • The standalone migrate experience is shown when clicking the primary button while the “Import from previous browser” checkbox is checked.
  • The "content-modal" prefs are set (enabled=true, behavior=default, import-all=false) after clicking the primary button while the “Import from previous browser” checkbox is unchecked.
  • In Nightly the default pref value for enabled is true, and in Beta/Release is false.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9334466 [details]
Bug 1833520 - Allow setting new migration prefs from about:welcome r?pdahiya,mconley

Approved for 114.0b6.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1eea4be12ff0

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using Firefox Beta 114.0b6 (Build ID: 20230518180043) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• After following the testing steps from this Test Plan, I confirm the following:
  • The "content-modal" prefs are set (enabled=true, behavior=standalone, import-all=true) after clicking the primary button while the “Import from previous browser” checkbox is checked.
  • The standalone migrate experience is shown when clicking the primary button while the “Import from previous browser” checkbox is checked.
  • The "content-modal" prefs are set (enabled=false, behavior=default, import-all=false) after clicking the primary button while the “Import from previous browser” checkbox is unchecked.
  • In Nightly the default pref value for enabled is true, and in Beta/Release is false.