1833585 - Middle-clicking the new tab button with an empty selection or clipboard opens a blank page without a title

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Kestrel]

Attachment: Blank tab created when middle-pasting empty spaces on new tab button

STR

1. On Ubuntu 23.04 with browser.tabs.searchclipboardfor.middleclick = true.
2. Select or copy some empty space characters in a document.
3. Click the new tab button with the middle mouse button.

Expected:
Nothing happens or a search is performed.

Actual:
A new tab is created with an empty page that has no title and the address bar contains the pasted content.

The tab initially gives the impression of being broken but continues to operate normally.

Console errors:

NS_ERROR_FAILURE: Should pass a non-null uri       URIFixup.sys.mjs:295
NS_ERROR_FAILURE: 
fixupAndLoadURIString resource://gre/modules/RemoteWebNavigation.sys.mjs:154
_internalMaybeFixupLoadURI chrome://browser/content/tabbrowser.js:7235
fixupAndLoadURIString chrome://browser/content/tabbrowser.js:7188
_kickOffBrowserLoad chrome://browser/content/tabbrowser.js:3095
addTab chrome://browser/content/tabbrowser.js:2784
openLinkIn resource:///modules/URILoadingHelper.sys.mjs:561
openTrustedLinkIn resource:///modules/URILoadingHelper.sys.mjs:716
openTrustedLinkIn chrome://browser/content/utilityOverlay.js:125
wrappedJSObject chrome://browser/content/browser.js:2903
BrowserOpenTab chrome://browser/content/browser.js:2899
handleNewTabMiddleClick chrome://browser/content/tabbrowser.js:4389
onclick chrome://browser/content/browser.xhtml:1

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1833585 - don't try to search for whitespace-only clipboard contents when middle-clicking new tab, r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc1bc442872d
don't try to search for whitespace-only clipboard contents when middle-clicking new tab, r=dao

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fc1bc442872d