1833624 - Call Ion RegExp stubs also from Baseline ICs

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

This improves a number of Speedometer 3 sub tests by a few % so seems worth doing:

https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=85301b329931b22faee6fcd3cf40ffcd682eddc4&originalSignature=4586009&newSignature=4586009&framework=13&application=firefox&originalRevision=abc8872d18e487c95cdae7f6a34be8e2e7ac6bd0&page=1

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1833624 part 1 - Move some RegExp stub constants to a header file. r?iain!

We need those to call the stubs from Baseline IC code.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1833624 part 2 - Add support for JitCode stub fields. r?iain!

The realm stubs are currently stored as weak references so the IC stub will need
to hold a strong reference to keep it alive.

Depends on D178328

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1833624 part 3 - Minor Realm and JitRealm changes. r?iain!

Depends on D178329

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1833624 part 4 - Call RegExp stubs also from Baseline ICs. r?iain!

This is faster, especially for the Matcher and ExecMatch stubs, because allocating
the match result array is faster from JIT code than from C++.

Speedometer 3 shows some medium/high confidence improvements for various sub tests.

Moving the input registers into place was one of the tricky parts. After trying a few
approaches, using MoveResolver was simplest so that's what this patch implements.

Because the regexp stubs are held weakly by JitRealm, this patch stores a strong
reference to the stub's JitCode in the IC stub. It isn't actually used for the call,
because there are some edge cases (that we shouldn't hit in practice) where we discard
JIT code including the regexp stubs, but this doesn't work for scripts active on the stack.
To make sure we always call the correct regexp stub code, we load it from JitRealm.

Depends on D178330

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8cddc45f713
part 1 - Move some RegExp stub constants to a header file. r=iain
https://hg.mozilla.org/integration/autoland/rev/096f776a3f68
part 2 - Add support for JitCode stub fields. r=iain
https://hg.mozilla.org/integration/autoland/rev/2e0fc6642fb8
part 3 - Minor Realm and JitRealm changes. r=iain
https://hg.mozilla.org/integration/autoland/rev/c19f93169200
part 4 - Call RegExp stubs also from Baseline ICs. r=iain

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8cddc45f713
https://hg.mozilla.org/mozilla-central/rev/096f776a3f68
https://hg.mozilla.org/mozilla-central/rev/2e0fc6642fb8
https://hg.mozilla.org/mozilla-central/rev/c19f93169200