1833693 - [Tabs tray to Compose] Refactor menu item creation out of `TabsTrayBanner`

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, task, P3)

Description

[Noah Bond [:007]]

Currently, the MenuItem creation is a huge block inside of TabsTrayBanner, and it'd benefit from relocating this logic into a different file (perhaps as an extension function for TabsTrayState). This way the logic isn't trapped inside of TabsTrayBanner but the it could covered with unit tests as well.

generateSingleSelectBannerMenuItems currently has the @Composable tag and uses stringResource and colorResource, so those may need to be removed in favor of using simple IDs.

colorResource can also be dropped, as the default color is textPrimary, which is being passed in here.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1833693: refactor menu items list creation (#3022)

Comment 2

[BMO Github Automation]

Authored by https://github.com/Alexandra-Virvara
https://github.com/mozilla-mobile/firefox-android/commit/52cd7d41972f63da7671a25f559c8fc2f42f8b49
[main] Bug 1833693: refactor menu items list creation out of TabsTray Banner

Comment 3

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest nightly 119.0a1 from 05.09.2023 with Motorola Moto G9 Plus (Android 11).
Ensuring that the tabs tray menus are unchanged and behave accordingly.