1833757 - [Tabs tray to Compose] Consolidate the `onTabMultiSelectClick` and `onTabClick` lambdas and move this logic into the Controller

Status: VERIFIED FIXED

(Fenix :: Tabs, task, P3)

Description

[Noah Bond [:007]]

There should, ideally, only be one lambda for handling tab clicks, and the Controller should be the one to handle whether the tab was clicked in one state (Mode) or another.

As part of this ticket:

• Consolidate the two tab click lambdas
• Add this logic bifurcation to TabsTrayController

Notes for QA:
This is a business logic refactor, so all currently functionality should be maintained after this ticket. Please do a simple validation to ensure there have been no behavior regressions around clicking to open tabs and tab multi-selection.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1833757 - Remove `onEnterMultiselectModeClick` parameter from `TabsTrayBanner` (#2208)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1833757 - Merge `onTabMultiSelectClick` and `onTabClick` lambdas (#2210)

Comment 3

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/56539b80f37d59b9abbacd36c899d17296f05590
[main] Bug 1833757 - Merge onTabMultiSelectClick and onTabClick lambdas

Comment 4

[Delia Pop]

Verified as fixed on the latest Nightly 115.0a1 from 05/26. No regressions were observed while testing the tabs opening/closing and multiple selection.
Devices used:

• LG G7 fit (Android 8.1.0)
• Samsung Galaxy A53 5G (Android 13)
• OPPO A15s (Android 10)