Closed
Bug 1833855
Opened 1 year ago
Closed 1 year ago
Make possible to create X11 and Wayland only builds
Categories
(Core :: Widget: Gtk, task, P3)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(15 files)
|
59.24 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Make possible to create X11 and Wayland only builds. We also should enable dmabuf/VA-API for X11 builds without Wayland support.
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(stransky)
Priority: -- → P3
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → stransky
Flags: needinfo?(stransky)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(stransky)
|
|
Assignee | |
Comment 1•1 year ago
|
||
A complete patch for testing. Will divide to small parts to land.
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(stransky)
|
|
Assignee | |
Comment 2•1 year ago
|
||
To support Wayland and X11 exclusive builds do:
- Add cairo-gtk3-x11-only build target
- Configure cairo-gtk3-wayland-only build target without X11
- Configure cairo-gtk3-x11-only target without Wayland support.
- Make EGL OpenGL backend default on Linux.
- Request libdrm >= 2.4 for Gtk3 build target to support dmabuf/va-api on X11 only builds.
|
|
Assignee | |
Comment 3•1 year ago
|
||
- VA-API doesn't need Wayland so enable it for Linux/Gtk3 target.
Depends on D178632
|
|
Assignee | |
Comment 4•1 year ago
|
||
Depends on D178633
|
|
Assignee | |
Comment 5•1 year ago
|
||
Depends on D178634
|
|
Assignee | |
Comment 6•1 year ago
|
||
Depends on D178635
|
|
Assignee | |
Comment 7•1 year ago
|
||
Depends on D178636
|
|
Assignee | |
Comment 8•1 year ago
|
||
Depends on D178637
|
|
Assignee | |
Comment 9•1 year ago
|
||
Depends on D178638
|
|
Assignee | |
Comment 10•1 year ago
|
||
Depends on D178639
|
|
Assignee | |
Comment 11•1 year ago
|
||
Depends on D178640
|
|
Assignee | |
Comment 12•1 year ago
|
||
Depends on D178641
|
|
Assignee | |
Comment 13•1 year ago
|
||
Depends on D178642
|
|
Assignee | |
Comment 14•1 year ago
|
||
Depends on D178643
|
|
Assignee | |
Comment 15•1 year ago
|
||
Depends on D178644
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(stransky)
|
|
Assignee | |
Comment 16•1 year ago
|
||
|
|
Assignee | |
Comment 17•1 year ago
|
||
|
|
Assignee | |
Comment 19•1 year ago
|
||
|
||
Comment 20•1 year ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/b8013c43aa20 [Linux] Create Wayland only and X11 only build targets r=glandium https://hg.mozilla.org/integration/autoland/rev/47a6e9ed8828 [Linux] Build VA-API support on Linux/Gtk3 and don't request Wayland support for it r=alwu https://hg.mozilla.org/integration/autoland/rev/3235825211f9 [Linux] Build dmabuf support on Linux/Gtk and don't request Wayland for it r=lsalzman https://hg.mozilla.org/integration/autoland/rev/6f94e3f002ed [Linux] Build widget.dmabuf preferences on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/b75750bb7596 [Linux] Build VA-API FFVPX support Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/15120d9c5b24 [Linux] Build mozva (VA-API library wrapper) on Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/4eb11068275d [Linux] Update glxtest to get DRM device on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/8d5d0690668c [Linux] Make sure we have correct display for X11 and Wayland exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/ea21e90a71dd [Linux] Update DMABufLibWrapper for X11 r=emilio https://hg.mozilla.org/integration/autoland/rev/2e49d43a627c [Linux] Update DMABufSurface to build on X11 only r=emilio https://hg.mozilla.org/integration/autoland/rev/013d1d16194d [Linux] Build and run vaapitest on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/2c0807d0b39a [Linux] Update GtkCompositorWidget to work on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/347c47f5542a [Linux] Update widget/gtk for wayland/x11 exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/c3f7d1963902 [Linux] Replace kIsX11 and kIsWayland with kIsLinux r=lsalzman
|
||
Comment 21•1 year ago
|
||
Backed out for causing build bustages in SharedSurface.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/gfx/gl/SharedSurface.cpp:103:19: error: no member named 'DMABufDevice' in namespace 'mozilla::widget'
Flags: needinfo?(stransky)
|
|
||
Comment 23•1 year ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/895b93846598 [Linux] Create Wayland only and X11 only build targets r=glandium https://hg.mozilla.org/integration/autoland/rev/d50ae530998d [Linux] Build VA-API support on Linux/Gtk3 and don't request Wayland support for it r=alwu https://hg.mozilla.org/integration/autoland/rev/7b4da292159c [Linux] Build dmabuf support on Linux/Gtk and don't request Wayland for it r=lsalzman https://hg.mozilla.org/integration/autoland/rev/a058367a436a [Linux] Build widget.dmabuf preferences on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/ac0947e6e601 [Linux] Build VA-API FFVPX support Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/b0a7ca2dfbd6 [Linux] Build mozva (VA-API library wrapper) on Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/9d5ae056d3c8 [Linux] Update glxtest to get DRM device on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/7f22e082786c [Linux] Make sure we have correct display for X11 and Wayland exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/3e6387b95e39 [Linux] Update DMABufLibWrapper for X11 r=emilio https://hg.mozilla.org/integration/autoland/rev/86948033f163 [Linux] Update DMABufSurface to build on X11 only r=emilio https://hg.mozilla.org/integration/autoland/rev/3b75e59357bb [Linux] Build and run vaapitest on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/2d4f6b8ad5d3 [Linux] Update GtkCompositorWidget to work on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/cc17af8bae3d [Linux] Update widget/gtk for wayland/x11 exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/b8daeb03b670 [Linux] Replace kIsX11 and kIsWayland with kIsLinux r=lsalzman
|
|
||
Comment 24•1 year ago
|
||
Backed out for causing build bustages in DMABufSurface.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/widget/gtk/DMABufSurface.cpp:741:3: error: use of undeclared identifier 'nsWaylandDisplay'; did you mean 'GdkIsWaylandDisplay'?
Flags: needinfo?(stransky)
|
|
||
Comment 26•1 year ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/491e57a77a6b [Linux] Create Wayland only and X11 only build targets r=glandium https://hg.mozilla.org/integration/autoland/rev/74118e122573 [Linux] Build VA-API support on Linux/Gtk3 and don't request Wayland support for it r=alwu https://hg.mozilla.org/integration/autoland/rev/8aff706aac3c [Linux] Build dmabuf support on Linux/Gtk and don't request Wayland for it r=lsalzman https://hg.mozilla.org/integration/autoland/rev/ce0f8fa9099e [Linux] Build widget.dmabuf preferences on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/08e4b602ab2d [Linux] Build VA-API FFVPX support Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/18587c671763 [Linux] Build mozva (VA-API library wrapper) on Linux/Gtk r=alwu https://hg.mozilla.org/integration/autoland/rev/82e75913321c [Linux] Update glxtest to get DRM device on Linux/Gtk r=emilio https://hg.mozilla.org/integration/autoland/rev/c60bbc22ec85 [Linux] Make sure we have correct display for X11 and Wayland exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/69f10aabe0f9 [Linux] Update DMABufLibWrapper for X11 r=emilio https://hg.mozilla.org/integration/autoland/rev/946ad32652de [Linux] Update DMABufSurface to build on X11 only r=emilio https://hg.mozilla.org/integration/autoland/rev/51f346fa06a4 [Linux] Build and run vaapitest on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/497a33d822b8 [Linux] Update GtkCompositorWidget to work on X11 only builds r=emilio https://hg.mozilla.org/integration/autoland/rev/ad7fbf10f3d8 [Linux] Update widget/gtk for wayland/x11 exclusive builds r=emilio https://hg.mozilla.org/integration/autoland/rev/36def4509c9c [Linux] Replace kIsX11 and kIsWayland with kIsLinux r=lsalzman
|
||
Comment 27•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/491e57a77a6b
https://hg.mozilla.org/mozilla-central/rev/74118e122573
https://hg.mozilla.org/mozilla-central/rev/8aff706aac3c
https://hg.mozilla.org/mozilla-central/rev/ce0f8fa9099e
https://hg.mozilla.org/mozilla-central/rev/08e4b602ab2d
https://hg.mozilla.org/mozilla-central/rev/18587c671763
https://hg.mozilla.org/mozilla-central/rev/82e75913321c
https://hg.mozilla.org/mozilla-central/rev/c60bbc22ec85
https://hg.mozilla.org/mozilla-central/rev/69f10aabe0f9
https://hg.mozilla.org/mozilla-central/rev/946ad32652de
https://hg.mozilla.org/mozilla-central/rev/51f346fa06a4
https://hg.mozilla.org/mozilla-central/rev/497a33d822b8
https://hg.mozilla.org/mozilla-central/rev/ad7fbf10f3d8
https://hg.mozilla.org/mozilla-central/rev/36def4509c9c
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
:stransky anything from here that you want to mention in the fx116 release notes?
Flags: needinfo?(stransky)
|
|
Assignee | |
Comment 29•11 months ago
|
||
(In reply to Dianna Smith [:diannaS] from comment #28)
:stransky anything from here that you want to mention in the fx116 release notes?
No need to mention that as it affects custom builds only.
Flags: needinfo?(stransky)
You need to log in
before you can comment on or make changes to this bug.
Description
•