1833950 - KWin on Wayland on my laptop asserts frequently mAnimation == nullptr

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

STR:

• On kwin on wayland run a debug build.
• Ctrl+P to enter print preview.
• Frequently scroll up and down.

I hit:

Assertion failure: mAnimation == nullptr, at /home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/AsyncPanZoomController.cpp:1856
#01: mozilla::layers::AsyncPanZoomController::HandleEndOfPan() (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/AsyncPanZoomController.cpp:1856)
#02: mozilla::layers::AsyncPanZoomController::OnPanEnd(mozilla::PanGestureInput const&) (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/AsyncPanZoomController.cpp:0)
#03: mozilla::layers::AsyncPanZoomController::HandleInputEvent(mozilla::InputData const&, mozilla::gfx::Matrix4x4Typed<mozilla::ScreenPixel, mozilla::ParentLayerPixel, float> const&) (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/AsyncPanZoomController.cpp:1117)
#04: mozilla::layers::InputQueue::ProcessQueue() (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/InputQueue.cpp:1012)
#05: mozilla::layers::InputQueue::ReceivePanGestureInput(RefPtr<mozilla::layers::AsyncPanZoomController> const&, mozilla::layers::TargetConfirmationFlags, mozilla::PanGestureInput const&) (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/InputQueue.cpp:0)
#06: mozilla::layers::InputQueue::ReceiveInputEvent(RefPtr<mozilla::layers::AsyncPanZoomController> const&, mozilla::layers::TargetConfirmationFlags, mozilla::InputData&, mozilla::Maybe<nsTArray<unsigned int> > const&) (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/InputQueue.cpp:0)
#07: mozilla::layers::APZCTreeManager::ReceiveInputEvent(mozilla::InputData&, std::function<void (unsigned long, mozilla::layers::APZHandledResult const&)>&&) (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/APZCTreeManager.cpp:1664)
#08: {virtual override thunk({offset(-16)}, mozilla::layers::APZCTreeManager::ReceiveInputEvent(mozilla::InputData&, std::function<void (unsigned long, mozilla::layers::APZHandledResult const&)>&&))} (/home/emilio/src/moz/mozilla-central/gfx/layers/apz/src/APZCTreeManager.cpp:0)
#09: nsWindow::DispatchPanGesture(mozilla::PanGestureInput&) (/home/emilio/src/moz/mozilla-central/widget/gtk/nsWindow.cpp:5116)
#10: nsWindow::OnScrollEvent(_GdkEventScroll*) (/home/emilio/src/moz/mozilla-central/widget/gtk/nsWindow.cpp:5048)
#11: scroll_event_cb(_GtkWidget*, _GdkEventScroll*) (/home/emilio/src/moz/mozilla-central/widget/gtk/nsWindow.cpp:0)
#12: ??? (/usr/lib/libgtk-3.so.0 + 0x84fd8)
#13: g_closure_invoke (/usr/lib/libgobject-2.0.so.0 + 0x14210)
#14: ??? (/usr/lib/libgobject-2.0.so.0 + 0x422f8)
#15: g_signal_emit_valist (/usr/lib/libgobject-2.0.so.0 + 0x31aa0)
#16: g_signal_emit (/usr/lib/libgobject-2.0.so.0 + 0x32324)
#17: ??? (/usr/lib/libgtk-3.so.0 + 0x344b25)
#18: ??? (/usr/lib/libgtk-3.so.0 + 0x1e20bb)
#19: gtk_main_do_event (/usr/lib/libgtk-3.so.0 + 0x1e2f9b)
#20: ??? (/usr/lib/libgdk-3.so.0 + 0x33b83)
#21: ??? (/usr/lib/libgdk-3.so.0 + 0x6be98)
#22: g_main_context_dispatch (/usr/lib/libglib-2.0.so.0 + 0x5a53b)
#23: ??? (/usr/lib/libglib-2.0.so.0 + 0xb7219)
#24: g_main_context_iteration (/usr/lib/libglib-2.0.so.0 + 0x591a2)
#25: nsAppShell::ProcessNextNativeEvent(bool) (/home/emilio/src/moz/mozilla-central/widget/gtk/nsAppShell.cpp:422)
#26: nsBaseAppShell::DoProcessNextNativeEvent(bool) (/home/emilio/src/moz/mozilla-central/widget/nsBaseAppShell.cpp:131)
#27: nsBaseAppShell::OnProcessNextEvent(nsIThreadInternal*, bool) (/home/emilio/src/moz/mozilla-central/widget/nsBaseAppShell.cpp:251)
#28: {virtual override thunk({offset(-8)}, nsBaseAppShell::OnProcessNextEvent(nsIThreadInternal*, bool))} (/home/emilio/src/moz/mozilla-central/widget/nsBaseAppShell.cpp:0)
#29: nsThread::ProcessNextEvent(bool, bool*) (/home/emilio/src/moz/mozilla-central/xpcom/threads/nsThread.cpp:1156)
#30: NS_ProcessNextEvent(nsIThread*, bool) (/home/emilio/src/moz/mozilla-central/xpcom/threads/nsThreadUtils.cpp:479)
#31: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) (/home/emilio/src/moz/mozilla-central/ipc/glue/MessagePump.cpp:85)
#32: MessageLoop::Run() (/home/emilio/src/moz/mozilla-central/ipc/chromium/src/base/message_loop.cc:345)
#33: nsBaseAppShell::Run() (/home/emilio/src/moz/mozilla-central/widget/nsBaseAppShell.cpp:150)
#34: nsAppStartup::Run() (/home/emilio/src/moz/mozilla-central/toolkit/components/startup/nsAppStartup.cpp:296)
#35: XREMain::XRE_mainRun() (/home/emilio/src/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:5670)
#36: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) (/home/emilio/src/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:5870)
#37: XRE_main(int, char**, mozilla::BootstrapConfig const&) (/home/emilio/src/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:5926)
#38: main (/home/emilio/src/moz/mozilla-central/browser/app/nsBrowserApp.cpp:445)
#39: ??? (/usr/lib/libc.so.6 + 0x23850)
#40: __libc_start_main (/usr/lib/libc.so.6 + 0x2390a)
#41: ??? (/home/emilio/src/moz/mozilla-central/obj-debug/dist/bin/firefox + 0x457d9)

It happens mostly on this laptop (dell XPS), I don't see the same on my desktop, so if you need a pernosco recording or something lmk.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

My desktop obviously doesn't have a trackpad...

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1833950 - Handle duplicate pan-end on fling state too. r=botond

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1833950 - Add gtest. r=dlrobertson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6960227dc6ec
Handle duplicate pan-end on fling state too. r=botond
https://hg.mozilla.org/integration/autoland/rev/56a15ad65227
Add gtest. r=dlrobertson

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6960227dc6ec
https://hg.mozilla.org/mozilla-central/rev/56a15ad65227