1833975 - Create a quick suggest test helper to mock remote settings data

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

Currently only one type of quick suggest result is fetched from remote settings, adM/Wikipedia, and the tests for these results add mock suggestion objects directly to AdmWikiedpia's suggestions map (here and here), completely bypassing the AdmWikipedia code that deals with remote settings.

That's bad because it doesn't exercise the code that deals with remote settings, and it also doesn't address all the new types of results we want to support that will also be fetched from remote settings. We should come up with a generalized test helper to set up mock data in remote settings. It might be as simple as stubbing QuickSuggestRemoteSettings.rs.get() like Daisuke did in this patch for addon suggestions.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1833975: Introduce MockRemoteSettings to sync RemoteSettings data

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1833975: Use MockRemoteSettings for QuickSuggestTestUtils.setRemoteSettingsResults()

Depends on D178789

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1833975: Use MockRemoteSettings for QuickSuggestTestUtils.setConfig

Depends on D178790

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1833975: Use rs instead of _test_rs

Depends on D178791

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43f66a49f875
Introduce MockRemoteSettings to sync RemoteSettings data r=adw
https://hg.mozilla.org/integration/autoland/rev/f6a474dcdc0e
Use MockRemoteSettings for QuickSuggestTestUtils.setRemoteSettingsResults() r=adw
https://hg.mozilla.org/integration/autoland/rev/22a19ef954b3
Use MockRemoteSettings for QuickSuggestTestUtils.setConfig r=adw
https://hg.mozilla.org/integration/autoland/rev/e06da1bd5237
Use rs instead of _test_rs r=adw

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_quicksuggest_positionInSuggestions.js

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7abb8859b9e
Introduce MockRemoteSettings to sync RemoteSettings data r=adw
https://hg.mozilla.org/integration/autoland/rev/64c4571a122e
Use MockRemoteSettings for QuickSuggestTestUtils.setRemoteSettingsResults() r=adw
https://hg.mozilla.org/integration/autoland/rev/24e76f31f305
Use MockRemoteSettings for QuickSuggestTestUtils.setConfig r=adw
https://hg.mozilla.org/integration/autoland/rev/ecb043fa32f3
Use rs instead of _test_rs r=adw

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c7abb8859b9e
https://hg.mozilla.org/mozilla-central/rev/64c4571a122e
https://hg.mozilla.org/mozilla-central/rev/24e76f31f305
https://hg.mozilla.org/mozilla-central/rev/ecb043fa32f3