1834014 - Add effects to always- and never-translate menuitems

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement)

Description

[Erik Nordin [:nordzilla]]

Bug 1829691 adds the always-translate and never-translate menuitems to the translations panel, but only hooks up the infrastructure to interact with the preferences and perform the correct actions upon loading a page.

This bug adds effects to the buttons that will trigger behaviors when clicked.

• always-translate language will immediately translate the page if not already translated.

• never-translate language will hide the translations button and restore the page if translated.

• never-translate site will hide the translations button and restore the page if translated.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Comment 6

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 8

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 9

[Erik Nordin [:nordzilla]]

Attachment: WIP: Bug 1834014 - Add effects to always- and never-translate menuitems

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 10

[Erik Nordin [:nordzilla]]

Attachment: Bug 1834014 - Add effects to always- and never-translate menuitems r=gregtatum!

Adds functionality to the following menuitems:

always-translate language will immediately translate
the page if not already translated.

never-translate language will hide the translations
button and restore the page if translated.

never-translate site will hide the translations
button and restore the page if translated.

Depends on D177860

Comment 11

[Erik Nordin [:nordzilla]]

Attachment: Bug 1834014 - Update always- and never-translate menuitem tests r=gregtatum!

Depends on D178512

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9c17faebbe3
Add effects to always- and never-translate menuitems r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/680e9579fca5
Update always- and never-translate menuitem tests r=gregtatum

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aa20cd839a4
Backed out 10 changesets (bug 1834014, bug 1829691) for causing failures at browser_about_translations_debounce.js. CLOSED TREE

Comment 14

[Atila Butkovits]

Backed out for causing failures at browser_about_translations_debounce.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6aa20cd839a4400c717350949739158101461a93

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=680e9579fca596578d9aef62f591ca54aeb34238&selectedTaskRun=IhzYcyDSTYKQdbnUWrbUCQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=416629920&repo=autoland&lineNumber=67237
https://treeherder.mozilla.org/logviewer?job_id=416630130&repo=autoland&lineNumber=106810
https://treeherder.mozilla.org/logviewer?job_id=416638395&repo=autoland&lineNumber=164030
https://treeherder.mozilla.org/logviewer?job_id=416629922&repo=autoland&lineNumber=21614

Comment 15

[Greg Tatum [:gregtatum]]

That kind of looks like Bug 1834067, I triggered more runs. We should probably just disable that test for now and follow-up.

Comment 16

[Erik Nordin [:nordzilla]]

This is an old intermittent issue from Bug 1821461 that we believed was fixed in this revision:
https://phabricator.services.mozilla.com/D178448#change-X4JCCMBxHUGV

The code that it tests is not part of the Translations MVP, and the code that landed in this bug does not touch this test at all.

I have re-disabled the test and I am re-landing.
https://phabricator.services.mozilla.com/D178723

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96dc91b50ecf
Add effects to always- and never-translate menuitems r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/bd3077e43541
Update always- and never-translate menuitem tests r=gregtatum

Comment 18

[Atila Butkovits]

Backed out for causing failures at browser_console_content_object_in_sidebar.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4da2b81752a7cf92c40f93504ba3565455b7d697

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=MA3PQiGFTSe4Qs9tN6rUWA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=bd3077e43541052162992d01242dacc56f37d221

Failure log:
Mn failure: https://treeherder.mozilla.org/logviewer?job_id=416668684&repo=autoland&lineNumber=17526
Bc failure: https://treeherder.mozilla.org/logviewer?job_id=416665343&repo=autoland&lineNumber=45431
Dt failure: https://treeherder.mozilla.org/logviewer?job_id=416665323&repo=autoland&lineNumber=27115
Bc failure: https://treeherder.mozilla.org/logviewer?job_id=416666436&repo=autoland&lineNumber=101525

Comment 19

[Erik Nordin [:nordzilla]]

Ah, how frustrating.

This is due to a misunderstanding of the value of the aDefaultValue parameter in defineLazyPreferenceGetter().

I've fixed the issue in this code, and also submitted a patch to clarify the defineLazyPreferenceGetter() code:
https://bugzilla.mozilla.org/show_bug.cgi?id=1834595

Here is a clean try run:

https://treeherder.mozilla.org/jobs?repo=try&revision=ae2ea7d713b62658e7710b0b0726ba423630b613&selectedTaskRun=EDGOF8GQQsicRk6QL3fZpQ.0

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7420159aa934
Add effects to always- and never-translate menuitems r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/56ff28106079
Update always- and never-translate menuitem tests r=gregtatum

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7420159aa934
https://hg.mozilla.org/mozilla-central/rev/56ff28106079