1834049 - Creating MediaRecorder on canvas stream without context causes `NS_ERROR_NOT_INITIALIZED`

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Jozef]

Attachment: canvas.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36

Steps to reproduce:

1. Open the provided page
2. Open console and you see the error

Actual results:

Error is thrown

Expected results:

No error thrown - chrome, safari works OK

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: Canvas2D' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Brad Werth [:bradwerth]]

I can reproduce. It's not clear that the spec requires the context to be created. I put together a quick patch to ignore that requirement and there was no error, but I'm not sure if that's a "fix". I'll upload the patch and ask Lee to review.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1834049: Permit canvas captureStream without initializing the context.

The spec does not seem to require a current context, so there's no reason
to require it here. If later calls within
HTMLCanvasElement::CaptureStream need a current context, they'll have
their own failure messages which will hopefully clarify where exactly we
need the context to exist.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d4600975de9
Permit canvas captureStream without initializing the context. r=lsalzman

Comment 5

[Cristian Tuns]

Backed out for causing wpt failures in MediaStreamTrack-contentHint.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /mst-content-hint/MediaStreamTrack-contentHint.html | Accepts valid video contentHints - expected FAIL

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1834049 Part 2: Update test expectations.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c07d9e5fbc57
Permit canvas captureStream without initializing the context. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/e06cac16fcf2
Part 2: Update test expectations. r=lsalzman

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c07d9e5fbc57
https://hg.mozilla.org/mozilla-central/rev/e06cac16fcf2