1834058 - Update PDF.js to new version 38287d943532eee939ceffbe6861163f93805ca7 from 2023-05-19 09:36:06

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 10 commits.. Here are the overall diff statistics, and then the commit information.

---

browser/locales/en-US/pdfviewer/viewer.properties | 2 +
toolkit/components/pdfjs/content/build/pdf.js | 35 +-
toolkit/components/pdfjs/content/build/pdf.scripting.js | 43 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 260 +++++++-------
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 10 +-
toolkit/components/pdfjs/content/web/viewer.js | 10 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
7 files changed, 166 insertions(+), 198 deletions(-)

---

8c4821ceda4cc70d478b471f4174972c25a38437 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/8c4821ceda4cc70d478b471f4174972c25a38437
Authored: 2023-05-18 22:23:42 +0200
Committed: 2023-05-18 22:32:10 +0200

[api-minor] Slightly shorten the marked-content ids used in the textLayer

Generally we try to keep the ids that we create short, hence we can slightly shorten the "static" parts of them.

Files Modified:

• src/core/document.js
• src/core/evaluator.js
• src/core/struct_tree.js
• test/unit/api_spec.js

---

04de155aaa495c9075e154c4c2c5e428a536e2cf by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/04de155aaa495c9075e154c4c2c5e428a536e2cf
Authored: 2023-05-18 22:13:15 +0200
Committed: 2023-05-18 22:27:11 +0200

Slightly shorten the loadedName-ids used with font-substitutions

Generally we try to keep the ids that we create short, hence we can slightly shorten the "static" part of them.

Files Modified:

• src/core/font_substitutions.js
• test/unit/font_substitutions_spec.js

---

3091e70aad24a3024ba7afc0f3e502248152068c by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/3091e70aad24a3024ba7afc0f3e502248152068c
Authored: 2023-05-18 17:22:42 +0200
Committed: 2023-05-18 19:37:16 +0200

Flush the current chunk when the font changed because of a restore op (issue #14755)

Files Added:

• test/pdfs/issue14755.pdf

Files Modified:

• src/core/evaluator.js
• test/pdfs/.gitignore
• test/unit/api_spec.js

---

e8030752f37a66ec73399d5494bb45ad5220deb5 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/e8030752f37a66ec73399d5494bb45ad5220deb5
Authored: 2023-05-18 18:52:54 +0200
Committed: 2023-05-18 18:55:41 +0200

Introduce even more modern JavaScript features in the code-base

After PR 12563 we're now free to use e.g. logical OR assignment, nullish coalescing, and optional chaining in the entire code-base.

Files Modified:

• src/core/ccitt.js
• src/core/colorspace.js
• src/core/document.js
• src/core/fonts.js
• src/core/xfa/formcalc_parser.js
• src/core/xfa/template.js
• src/display/canvas.js
• src/display/display_utils.js
• src/scripting_api/field.js
• web/chromecom.js

---

77f8fd91ecd41434f61a291769211f8eb4355405 by Marco Castelluccio

https://github.com/mozilla/pdf.js/commit/77f8fd91ecd41434f61a291769211f8eb4355405
Authored: 2023-05-18 15:01:23 +0200
Committed: 2023-05-18 16:43:12 +0200

Add a localization note to explain that 'Open in app' strings are for mobile (bug 1833858)

Files Modified:

• l10n/en-US/viewer.properties

---

4355e76c603f2944228c380ba66770ecd4227ab1 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/4355e76c603f2944228c380ba66770ecd4227ab1
Authored: 2023-05-17 23:51:24 +0200
Committed: 2023-05-18 13:09:08 +0200

Simplify the fontID handling in PartialEvaluator.loadFont

The fontID handling is quite old and predates the use of the idFactory to generate a unique id for each font, hence we can simplify this code a little bit.

Files Modified:

• src/core/evaluator.js

---

177036e6aee6c7b31d8aa0b5ab0de3cd3aef824e by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/177036e6aee6c7b31d8aa0b5ab0de3cd3aef824e
Authored: 2023-05-16 23:03:01 +0200
Committed: 2023-05-17 14:07:28 +0200

For text widgets, get the text from the AP stream instead of from the format callback (bug 1825002)

When fixing bug 1766987, I thought the field formatted value came from
the result of the format callback: I was wrong. The format callback is ran
but the value is unused (maybe it's useful to set some global vars... or
it's just a bug in Acrobat). Anyway the value to display is the one rendered
in the AP stream.
The field value setter has been simplified and that fixes issue #16409.

Files Added:

• test/pdfs/bug1825002.pdf

Files Modified:

• src/core/annotation.js
• src/display/annotation_layer.js
• src/scripting_api/event.js
• src/scripting_api/field.js
• test/integration/scripting_spec.js
• test/pdfs/.gitignore

---

bfb374dbf66cc061b015853a57a85fed76d9119b by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/bfb374dbf66cc061b015853a57a85fed76d9119b
Authored: 2023-05-17 10:19:14 +0200
Committed: 2023-05-17 11:41:08 +0200

Attempt to fallback to a default font, for non-available ones, in more cases (issue 16432)

This essentially extends PR 11218 to also apply when looking up the final font-reference, via the XRef-table, fails because the font isn't available.

This patch also changes PartialEvaluator.fallbackFontDict to simply use "Helvetica" as the default font-name, since that seems generally reasonable given the now existing font-substitution code.

Files Added:

• test/pdfs/issue16432.pdf.link

Files Modified:

• src/core/evaluator.js
• test/test_manifest.json

---

385f275ad994217bc839f93d62a011fe635cbaaf by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/385f275ad994217bc839f93d62a011fe635cbaaf
Authored: 2023-05-16 14:58:38 +0200
Committed: 2023-05-16 14:58:38 +0200

Warn when pdf.js can't load an OS font

Files Modified:

• src/core/font_substitutions.js
• src/display/font_loader.js
• test/unit/font_substitutions_spec.js

---

1b4a7c5965dee7fbce8f801fa30d5f3fc92be183 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/1b4a7c5965dee7fbce8f801fa30d5f3fc92be183
Authored: 2023-05-15 12:38:28 +0200
Committed: 2023-05-15 12:38:28 +0200

Introduce more optional chaining in the src/core/ folder

After PR 12563 we're now free to use optional chaining in the worker-thread as well. (This patch also fixes one previously "missed" case in the web/ folder.)

For the MOZCENTRAL build-target this patch reduces the total bundle-size by 1.6 kilobytes.

Files Modified:

• src/core/annotation.js
• src/core/catalog.js
• src/core/ccitt.js
• src/core/cff_font.js
• src/core/cff_parser.js
• src/core/core_utils.js
• src/core/crypto.js
• src/core/dataset_reader.js
• src/core/decode_stream.js
• src/core/decrypt_stream.js
• src/core/document.js
• src/core/evaluator.js
• src/core/font_renderer.js
• src/core/fonts.js
• src/core/function.js
• src/core/image.js
• src/core/image_utils.js
• src/core/jpg.js
• src/core/operator_list.js
• src/core/parser.js
• src/core/primitives.js
• src/core/struct_tree.js
• src/core/unicode.js
• src/core/xfa/template.js
• src/core/xml_parser.js
• src/core/xref.js
• web/app.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=f672b500dbbfe7892a50c7ecae330430b8c4ffab

Comment 2

[Update Bot]

Attachment: Bug 1834058 - Update PDF.js to 38287d943532eee939ceffbe6861163f93805ca7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d52c0bac497a
Update PDF.js to 38287d943532eee939ceffbe6861163f93805ca7 r=marco,pdfjs-reviewers

Comment 4

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d52c0bac497a