Running an experiment setting Nimbus.search.experiment, could cause the settings to be lost
Categories
(Firefox :: Search, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
I noticed in digging into our Nimbus set-up that if Nimbus.search.experiment is set, when we restart we run the search service initialisation without the experiment value set, and then reload engines with the value set.
If we had an experiment that was testing adding engines, or maybe setting the default, then starting up in this manner could cause data loss for the user.
Although we don't have any experiments planning on using this, I'd like to address it now before it gets forgotten.
The way to address this is to set isEarlyStartup, so that the value is available during the early startup phase.
However, we also have a set of features where we would like to avoid reloading the engines and don't need isEarlyStartup.
Given that Nimbus will soon have multi-feature support, we can separate out the early startup ones into a different section.
|
Assignee | |
Comment 1•2 years ago
|
||
This separates out the two sets of variables to move the ones in early startup into searchConfiguration.
This will avoid reloading the search engines on startup for most experiments, and ensure that
the experiment is handled correctly for configurations.
The default private handling is retained within the early startup section, as that has an effect on default
search engines which may be affected if engines are loaded without those flags in place.
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•