Closed
Bug 1834100
Opened 2 years ago
Closed 2 years ago
Consider creating a timing distribution for the heaviest process in SearchSERPTelemetryChild
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
115 Branch
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: jteow, Assigned: jteow)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
2.65 KB,
text/plain
|
jhirsch
:
data-review+
|
Details |
Parsing the anchors and categorizing DOM elements can be an expensive operation.
We've been doing testing on a couple machines to do sanity checks that the processing time isn't crazy, but we could be more exhaustive by gathering info using a Glean timing distribution.
Relevant links:
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D178911
Updated•2 years ago
|
Assignee: nobody → jteow
Attachment #9335943 -
Attachment description: WIP: - Bug 1834100 - Use timing distribution for categorizing components in SearchSERPTelemetryChild - r?standard8,scunnane → Bug 1834100 - Use timing distribution for categorizing components in SearchSERPTelemetryChild - r?standard8,scunnane
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•2 years ago
|
||
Attachment #9336411 -
Flags: data-review?(jhirsch)
Comment 3•2 years ago
|
||
Comment on attachment 9336411 [details]
data-review-bug-1834100.md
data-review+, LGTM
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, the usual Firefox Glean documentation.
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, the usual Firefox telemetry opt-out.
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Yes, the search team will monitor via the fx-search-telemetry@mozilla.com alias.
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1: technical data.
- Is the data collection request for default-on or default-off?
Default-on.
- Does the instrumentation include the addition of any new identifiers?
No.
- Is the data collection covered by the existing Firefox privacy notice?
Yes.
- Does the data collection use a third-party collection tool?
No.
Attachment #9336411 -
Flags: data-review?(jhirsch) → data-review+
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e9d51287c53
Use timing distribution for categorizing components in SearchSERPTelemetryChild - r=Standard8
Comment 5•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•