1834176 - Convert NetUtils.jsm to an ES module

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Mark Banner (:standard8)]

As part of the ongoing work, we should convert NetUtils.jsm to an ES module.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1834176 - Avoid using NetUtil as a test file in js/xpconnect/tests. r?arai!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r?arai!

Depends on D178588

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2f0837b528
Avoid using NetUtil as a test file in js/xpconnect/tests. r=arai
https://hg.mozilla.org/integration/autoland/rev/57876d77a652
Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=TuaqUTN0TYSpUpBbIb1x8w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=57876d77a652c33d1fa6ed788d38937a626eb359

Logs: https://treeherder.mozilla.org/logviewer?job_id=416685705&repo=autoland&lineNumber=6025
mochitests:
https://treeherder.mozilla.org/logviewer?job_id=416687832&repo=autoland&lineNumber=2005
https://treeherder.mozilla.org/logviewer?job_id=416685704&repo=autoland&lineNumber=2259
https://treeherder.mozilla.org/logviewer?job_id=416687317&repo=autoland&lineNumber=1958

Backout: https://hg.mozilla.org/integration/autoland/rev/56c32e84cccddbf5da43e0ba44a2cca2559c1fe6

Comment 5

[Mark Banner (:standard8)]

Looks like Android can't use the TestFile.jsm, so I switched to TestBlob.jsm instead.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74d1880272d3
Avoid using NetUtil as a test file in js/xpconnect/tests. r=arai
https://hg.mozilla.org/integration/autoland/rev/ea1d8b634bfc
Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1834222 for causing RemoteProcessMonitor failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/5a7ac428b1fff61f6d06b836a521aa5e34f459bb

Comment 8

[Mark Banner (:standard8)]

The test failures are because hostutils need updating for the renamed NetUtil.sys.mjs file.

Given that once the file is renamed we can still use NetUtil.jsm to load the import, I'm going with: 1) land the rename, 2) get hostutils updated, 3) land the import changes. Hopefully that will work.

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1834176 - Convert NetUtil.jsm to an ES module. r?arai!

Depends on D178588

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f17584d19ea7
Avoid using NetUtil as a test file in js/xpconnect/tests. r=arai
https://hg.mozilla.org/integration/autoland/rev/2cc40181bae9
Convert NetUtil.jsm to an ES module. r=necko-reviewers,valentin

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out for having an unreferenced file in NetUtil.sys.mjs

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2cc40181bae9b56e5dc330f3194d683ae1a26167&selectedTaskRun=HboUapJ8S9GnJLLKqirVLQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=416898872&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d72053d9305f1dae27f538650b5119b616bf11b8

Comment 12

[Mark Banner (:standard8)]

I'm going to add a temporary exception for the unreferenced file so that the staged landing works.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd56014074a9
Avoid using NetUtil as a test file in js/xpconnect/tests. r=arai
https://hg.mozilla.org/integration/autoland/rev/d8ee1fe4340a
Convert NetUtil.jsm to an ES module. r=necko-reviewers,valentin

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fd56014074a9
https://hg.mozilla.org/mozilla-central/rev/d8ee1fe4340a

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ee71fd842f2
Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5ee71fd842f2