1834238 - "An engine with that name already exists!" message whitelisting doesn't work anymore - xpcshell.ini:toolkit/components/search/tests/xpcshell/test_webextensions_upgrade.js | test_upgrade_to_existing_name_not_allowed - [test_upgrade_to_existing_name_not_all

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Magnus Melin [:mkmelin]]

Thunderbird tests are failing with
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/search/tests/xpcshell/test_webextensions_upgrade.js | test_upgrade_to_existing_name_not_allowed - [test_upgrade_to_existing_name_not_allowed : 1] Unexpected console message received during test: An engine called engine1 already exists! - false == true

I don't know why Firefox doesn't hit this case, but test_webextensions_upgrade.js was (and is) specifically allowing that message, so it needs to be updated after the message was updated in https://hg.mozilla.org/mozilla-central/rev/ce23c5fc9dc44b2fa666356b9534907675e1b36e#l1.35

Comment 1

[Magnus Melin [:mkmelin]]

Same for test_webextensions_install.js
E.g. https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=bB_dJleyQH--V-U7bLm0dQ.0

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1834238 - update allowed console message for test_webextensions_upgrade.js after the message was updated in bug 1833848. r=standard8

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833848

Comment 4

[Intermittent Failures Robot]

15 failures in 3578 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 15

Platform and build breakdown:

• windows11-64-2009-qr: 4
  • debug: 2
  • opt: 2
• windows11-32-2009-qr: 2
  • opt: 1
  • debug: 1
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1834238&startday=2023-05-15&endday=2023-05-21&tree=all

Comment 5

[Mark Banner (:standard8)]

It took a little while for me to find why, but got there. Firefox's addSearchEngine uses Cu.reportError, Thunderbird's clone uses console.error.

At the moment, the console tracking is obviously not picking up Cu.reportError. I'm not sure that's worth fixing at the moment, as we're working towards removing `Cu.reportError (bug 877389).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7182040ba453
update allowed console message for test_webextensions_upgrade.js after the message was updated in bug 1833848. r=Standard8

Comment 7

[Intermittent Failures Robot]

16 failures in 630 pushes (0.025 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-qr: 4
  • debug: 2
  • opt: 2
• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1834238&startday=2023-05-22&endday=2023-05-22&tree=all

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7182040ba453

Comment 9

[Intermittent Failures Robot]

16 failures in 3946 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-qr: 4
  • debug: 2
  • opt: 2
• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1834238&startday=2023-05-22&endday=2023-05-28&tree=all