Closed Bug 1834238 Opened 1 year ago Closed 11 months ago

"An engine with that name already exists!" message whitelisting doesn't work anymore - xpcshell.ini:toolkit/components/search/tests/xpcshell/test_webextensions_upgrade.js | test_upgrade_to_existing_name_not_allowed - [test_upgrade_to_existing_name_not_all

Categories

(Firefox :: Search, defect)

defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox113 --- unaffected
firefox114 --- unaffected
firefox115 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Thunderbird tests are failing with
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/search/tests/xpcshell/test_webextensions_upgrade.js | test_upgrade_to_existing_name_not_allowed - [test_upgrade_to_existing_name_not_allowed : 1] Unexpected console message received during test: An engine called engine1 already exists! - false == true

I don't know why Firefox doesn't hit this case, but test_webextensions_upgrade.js was (and is) specifically allowing that message, so it needs to be updated after the message was updated in https://hg.mozilla.org/mozilla-central/rev/ce23c5fc9dc44b2fa666356b9534907675e1b36e#l1.35

Set release status flags based on info from the regressing bug 1833848

It took a little while for me to find why, but got there. Firefox's addSearchEngine uses Cu.reportError, Thunderbird's clone uses console.error.

At the moment, the console tracking is obviously not picking up Cu.reportError. I'm not sure that's worth fixing at the moment, as we're working towards removing `Cu.reportError (bug 877389).

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/integration/autoland/rev/7182040ba453
update allowed console message for test_webextensions_upgrade.js after the message was updated in bug 1833848. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: