1834249 - Grids in shadow dom are not listed in the "Grid" section

Status: VERIFIED FIXED

(DevTools :: Inspector: Layout, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the attached shadow-grid.html page
2. Open the inspector
3. Select the Layout panel

Expected results

There should be an element in the "Grid" section

Actual results

There is none

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: shadow-grid.html

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

It looks like this should be handled in Element::GetElementsWithGrid (https://searchfox.org/mozilla-central/rev/b63f8c50a3398aff80d2a5f185a90dcdba47f419/dom/base/Element.cpp#2127-2154).
Emilio, would it be hard to go through the shadow dom there?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

No, you probably want to use StyleChildrenIterator or FlattenedTreeIterator depending on whether you care about pseudo elements or not.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1834249 - [devtools] Return shadow DOM grid containers in Element::GetElementsWithGrid. r=emilio.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1834249 - [devtools] Add test for pseudo-element and shadow DOM grid containers. r=#devtools.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6ac0eaec09eb
https://hg.mozilla.org/integration/autoland/rev/709374377209
[devtools] Return shadow DOM grid containers in Element::GetElementsWithGrid. r=emilio.
https://github.com/mozilla-firefox/firefox/commit/6da43d86ae25
https://hg.mozilla.org/integration/autoland/rev/9f8e2731b18a
[devtools] Add test for pseudo-element and shadow DOM grid containers. r=devtools-reviewers,jdescottes.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/709374377209
https://hg.mozilla.org/mozilla-central/rev/9f8e2731b18a

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2025-07-14 Firefox Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 143.0a1 and Firefox 142.0b4 on Windows 10, Ubuntu 22, macOS 15.