1834270 - DM rooms can get duplicated under certain conditions

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Martin Giger [:freaktechnik]]

Okay, this is a very fun bug about how DM rooms work in Matrix.

Steps to reproduce:

• Get invited to a DM room
• Have a third party join
• Have the initial creator leave the room

Expected result: TB now treats the room as a DM room between the third party and you, even though it does not have the DM room metadata for that.

Actual result: TB creates a new DM room with the third party on every startup, because the room isn't correctly registered in the account data (but has the correct interluctor user ID).

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1834270 - Avoid creating new DM rooms from sync. r=clokep

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d1b467bfd990
Avoid creating new DM rooms from sync. r=clokep

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9335174 [details]
Bug 1834270 - Avoid creating new DM rooms from sync. r=clokep

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Connecting a Matrix account can create one ore more unexpected new direct conversation rooms.
Testing completed (on c-c, etc.): Manual testing.
Risk to taking this patch (and alternatives if risky): Alters logic how and when we create direct message conversations. So in terms of Matrix functionality maybe medium.

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9335174 [details]
Bug 1834270 - Avoid creating new DM rooms from sync. r=clokep

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/2213d9816156