1834388 - Make dynamic-range media features eval to unknown in single context.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1834388 - Make dynamic-range features eval to unknown in the boolean context.

As I wrote this I realized that it doesn't match the spec.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1834388 - Fix dynamic-range WPT tests for the boolean context. r=CanadaHonk,#style

https://drafts.csswg.org/mediaqueries-5/#mq-boolean-context is pretty
clear:

If the feature would be true for any value other than the number 0, a
<dimension> with the value 0, the keyword none, or a value explicitly
defined by that media feature to evaluate as false in a boolean
context, the media feature evaluates to true.
Otherwise, it evaluates to false.

These hit the "otherwise". The unknown behavior might make sense, but if
someone wants it the spec needs to change (for all media features
consistently).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10ef626b7f82
Fix dynamic-range WPT tests for the boolean context. r=CanadaHonk

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40146 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing wpt failures on dynamic-range.html

Backout link

Push with failures

Failure log

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1342b9fef6
Fix dynamic-range WPT tests for the boolean context. r=CanadaHonk

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7d1342b9fef6

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot