1834483 - Add public API to set or calculate JS::NativeStackLimit for JS::FrontendContext APIs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

For JSContext-based API, the stack quota is set by JS_SetNativeStackQuota.
We need the equivalent for JS::FrontendContext-based API, because the current JS::NativeStackLimit parameter is hard to use without at least helper to calculate it from size.

Comment 1

[Tooru Fujisawa [:arai]]

possible options:

• a) add JS::NativeStackLimit JS::GetNativeStackLimit(JS::NativeStackSize size);, which is combination of js::GetNativeStackLimit + js::GetNativeStackBase, and use it when calling compilation APIs
• b) add void JS::SetNativeStackQuota(JS::FrontendContext* fc, JS::NativeStackSize size);, which is JS::FrontendContext-variant of JS_SetNativeStackQuota for JSContext, and also add JS::NativeStackLimit field to JS::FrontendContext and remove JS::NativeStackLimit parameter from JS::FrontendContext-based APIs

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 1: Add NativeStackLimit field to FrontendContext. r?bthrall!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 2: Use FrontendContext NativeStackLimit field in ParseTask and DelazifyTask. r?bthrall!

Depends on D179002

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 3: Remove NativeStackLimit parameter from public FrontendContext-based API. r?bthrall!

Depends on D179003

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 4: Remove NativeStackLimit parameter from private FrontendContext-based compile to global API. r?bthrall!

Depends on D179004

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 5: Remove NativeStackLimit parameter from private FrontendContext-based compile to module API. r?bthrall!

Depends on D179005

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 6: Remove NativeStackLimit parameter from private FrontendContext-based delazify API. r?bthrall!

Depends on D179006

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 7: Remove NativeStackLimit field from SourceAwareCompiler. r?bthrall!

Depends on D179007

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 8: Remove NativeStackLimit field from Parser and BytecodeEmitter. r?bthrall!

Depends on D179008

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 9: Remove NativeStackLimit field from AsmJS module validator. r?bthrall!

Depends on D179009

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 10: Remove NativeStackLimit parameter from smoosh API. r?bthrall!

Depends on D179010

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1834483 - Part 11: Add JS::SetNativeStackQuota for JS::FrontendContext. r?bthrall!

Depends on D179011

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fce0bc3f10ec
Part 1: Add NativeStackLimit field to FrontendContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/578fed7f201b
Part 2: Use FrontendContext NativeStackLimit field in ParseTask and DelazifyTask. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/248999f3a826
Part 3: Remove NativeStackLimit parameter from public FrontendContext-based API. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/54bc516f4981
Part 4: Remove NativeStackLimit parameter from private FrontendContext-based compile to global API. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/e64f38a183a1
Part 5: Remove NativeStackLimit parameter from private FrontendContext-based compile to module API. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/a12fb416dc16
Part 6: Remove NativeStackLimit parameter from private FrontendContext-based delazify API. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/ea422269d9ab
Part 7: Remove NativeStackLimit field from SourceAwareCompiler. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/28edc29c161b
Part 8: Remove NativeStackLimit field from Parser and BytecodeEmitter. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/cceddc6d6dd4
Part 9: Remove NativeStackLimit field from AsmJS module validator. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/447bcdef4023
Part 10: Remove NativeStackLimit parameter from smoosh API. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/e7766c02eb55
Part 11: Add JS::SetNativeStackQuota for JS::FrontendContext. r=bthrall

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fce0bc3f10ec
https://hg.mozilla.org/mozilla-central/rev/578fed7f201b
https://hg.mozilla.org/mozilla-central/rev/248999f3a826
https://hg.mozilla.org/mozilla-central/rev/54bc516f4981
https://hg.mozilla.org/mozilla-central/rev/e64f38a183a1
https://hg.mozilla.org/mozilla-central/rev/a12fb416dc16
https://hg.mozilla.org/mozilla-central/rev/ea422269d9ab
https://hg.mozilla.org/mozilla-central/rev/28edc29c161b
https://hg.mozilla.org/mozilla-central/rev/cceddc6d6dd4
https://hg.mozilla.org/mozilla-central/rev/447bcdef4023
https://hg.mozilla.org/mozilla-central/rev/e7766c02eb55