1834531 - Perma /webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html | measure raising video jitterBufferTarget to 250 - assert_between_inclusive: video delay is within bounds rateOfChange ... when Gecko 115 merges to Beta on 2023-06-05

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Noemi Erli[:noemi_erli]]

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:
Failure log

task 2023-05-23T12:07:03.494Z] 12:07:03 INFO - TEST-START | /upgrade-insecure-requests/gen/iframe-blank-inherit.meta/upgrade/fetch.https.html
[task 2023-05-23T12:07:03.498Z] 12:07:03 INFO - Closing window 9fdbdbb9-87c9-4570-bf09-deaa6a79bd6b
[task 2023-05-23T12:07:04.075Z] 12:07:04 INFO - PID 31094 | [Parent 31094, Main Thread] WARNING: NS_ENSURE_TRUE(she && she->mInfo->mSharedState.Get()) failed: file /builds/worker/checkouts/gecko/docshell/shistory/SessionHistoryEntry.cpp:1156
[task 2023-05-23T12:07:04.225Z] 12:07:04 INFO - PID 31094 | [Parent 31094, Main Thread] WARNING: NS_ENSURE_TRUE(she && she->mInfo->mSharedState.Get()) failed: file /builds/worker/checkouts/gecko/docshell/shistory/SessionHistoryEntry.cpp:1156
[task 2023-05-23T12:07:04.375Z] 12:07:04 INFO - PID 794 | [Child 957: Main Thread]: I/signaling [main|PeerConnectionImpl] PeerConnectionImpl.cpp:2608: Close: Closing PeerConnectionImpl {ffbef60c-ff00-46e3-a420-a86440c51ce7}; ending call
[task 2023-05-23T12:07:04.376Z] 12:07:04 INFO - PID 794 | [Child 957: Main Thread]: I/jsep [{ffbef60c-ff00-46e3-a420-a86440c51ce7} 1684843503711557 (id=6442450950 url=http://web-platform.test:8000/webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html)]: stable -> closed
[task 2023-05-23T12:07:04.378Z] 12:07:04 INFO - PID 794 | [Child 957: Main Thread]: I/signaling [main|PeerConnectionImpl] PeerConnectionImpl.cpp:2608: Close: Closing PeerConnectionImpl {7402fce6-b022-47c3-adbb-2ac1a567883c}; ending call
[task 2023-05-23T12:07:04.380Z] 12:07:04 INFO - PID 794 | [Child 957: Main Thread]: I/jsep [{7402fce6-b022-47c3-adbb-2ac1a567883c} 1684843503713151 (id=6442450950 url=http://web-platform.test:8000/webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html)]: stable -> closed
[task 2023-05-23T12:07:04.392Z] 12:07:04 INFO - PID 794 | [Child 957: WebrtcWorker #4]: I/signaling [WebrtcWorker #4|WebrtcVideoSessionConduit] VideoStreamFactory.cpp:188: CreateEncoderStreams Input frame 640x480, RID scaling to 640x480
[task 2023-05-23T12:07:04.394Z] 12:07:04 INFO - PID 31094 | [Parent 31094, Main Thread] WARNING: NS_ENSURE_TRUE(she && she->mInfo->mSharedState.Get()) failed: file /builds/worker/checkouts/gecko/docshell/shistory/SessionHistoryEntry.cpp:1156
[task 2023-05-23T12:07:04.394Z] 12:07:04 INFO - PID 794 | [Child 957: WebrtcWorker #4]: I/signaling [WebrtcWorker #4|WebrtcVideoSessionConduit] VideoStreamFactory.cpp:209: CreateEncoderStreams Stream with RID maxFps=60 (global max fps = 60)
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO -
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - TEST-PASS | /webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html | measure raising video jitterBufferTarget to 250
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - TEST-PASS | /webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html | measure raising audio jitterBufferTarget to 250
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - TEST-UNEXPECTED-FAIL | /webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html | measure raising video jitterBufferTarget to 500 - assert_between_inclusive: video delay is within bounds rateOfChange 0.2736842105263002 over 39 measurements expected a number greater than or equal to 350 and less than or equal to 650 but got 324.36666666666645
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - measureDelayFromStats/<@http://web-platform.test:8000/webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html:92:40
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-05-23T12:07:04.461Z] 12:07:04 INFO - measureDelayFromStats@http://web-platform.test:8000/webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html:92:5
[task 2023-05-23T12:07:04.465Z] 12:07:04 INFO - .....

Dan, this seems to be a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1834369. Could you please take a look at this?

Comment 1

[Dan Baker[:dbaker]]

I'm going to remove the larger jitterBufferTarget values being tested. Hopefully this will allow the test to pass consistently on slower machines.

Comment 2

[Dan Baker[:dbaker]]

Attachment: Bug 1834531 - Removed larger test values to improve test performance.r?jib

Comment 3

[Cosmin Sabou [:CosminS]]

Patch works in today's beta-sim.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93d1b1ef74ee
Removed larger test values to improve test performance.r=jib

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93d1b1ef74ee

Comment 7

[Norisz Fay [:noriszfay]]

Verified fixed in today's central as beta-simulation

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40452 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot