1834537 - Simplify allocation code and make it more generic

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

This is a for a bunch more refactoring in preparation for inlining more of the allocation path.

Most of the patches relate to reducing duplication and making allocation methods common between the different trace kinds.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 1: Simplify JIT nursery allocation r?jandem

Since we discard JIT code when enabling/disabling nursery allocation of
different kinds, we don't need to use specific nursery end pointers to check
whether that kind is enabled any more.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 2: Fix nursery allocatable flag for objects with foreground finalizers r?sfink

Objects with foreground finalizers can be allocated in the nursery if the
JSCLASS_SKIP_NURSERY_FINALIZE flag is specified.

Depends on D178807

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 2: Replace nursery allocation methods with use ofuse allocateCell r?sfink

Depends on D178808

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 3: Add a generic tryNewNurseryCell method to GCRuntime r?sfink

This replaces individual methods for different trace kinds.

Depends on D178809

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 4: Make a generic function to allocate a cell in either the nursery or the tenured heap r?sfink

This is templated on trace kind and AllowGC and instantiated for every combination.

Depends on D178810

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 5: Rename allocator methods for consistency and simplicity r?sfink

This renames the methods called by NewCell into NewBlah, since like |new| they
do both allocation and construction.

The cell allocation methods are renamed to be slightly shorter because the
names are getting unwieldy.

Depends on D178811

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1834537 - Part 6: Simplify GCRuntime::checkAllocatorState a little r?sfink

This makes allowGC checks constexpr to make it clearer that these parts are
conditionally compiled.

gcIfNeededAtAllocation always returns true so we can remove the return value.

Depends on D178812

Comment 8

[Phabricator Automation]

Comment on attachment 9335453 [details]
Bug 1834537 - Part 2: Fix nursery allocatable flag for objects with foreground finalizers r?sfink

Revision D178808 was moved to bug 1834993. Setting attachment 9335453 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b48e468f29c1
Part 1: Simplify JIT nursery allocation r=jandem
https://hg.mozilla.org/integration/autoland/rev/834625707519
Part 2: Replace nursery allocation methods with use ofuse allocateCell r=sfink
https://hg.mozilla.org/integration/autoland/rev/6a44dedea3ad
Part 3: Add a generic tryNewNurseryCell method to GCRuntime r=sfink
https://hg.mozilla.org/integration/autoland/rev/aa8117171a65
Part 4: Make a generic function to allocate a cell in either the nursery or the tenured heap r=sfink
https://hg.mozilla.org/integration/autoland/rev/93b8493126c5
Part 5: Rename allocator methods for consistency and simplicity r=sfink
https://hg.mozilla.org/integration/autoland/rev/4651a95b056e
Part 6: Simplify GCRuntime::checkAllocatorState a little r=sfink

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b48e468f29c1
https://hg.mozilla.org/mozilla-central/rev/834625707519
https://hg.mozilla.org/mozilla-central/rev/6a44dedea3ad
https://hg.mozilla.org/mozilla-central/rev/aa8117171a65
https://hg.mozilla.org/mozilla-central/rev/93b8493126c5
https://hg.mozilla.org/mozilla-central/rev/4651a95b056e