please add herald rules for taskgraph-reviewers and releng-reviewers
Categories
(Conduit :: Administration, task)
Tracking
(Not tracked)
People
(Reporter: bhearsum, Unassigned)
Details
We'd like to get two new Herald rules for the Gecko repo added as follows:
taskgraph-reviewers should be flagged for everything in /taskcluster/gecko_taskgraph.
releng-reviewers should be flagged for all of the following:
/.taskcluster.yml/taskcluster/config.yml/taskcluster/.*attribution.*/taskcluster/.*balrog.*/taskcluster/.*beetmover.*/taskcluster/.*bouncer.*/taskcluster/.*mar.*/taskcluster/.*merge_automation.*/taskcluster/.*notarization.*/taskcluster/.*openh264.*/taskcluster/.*partials.*/taskcluster/.*partner.*/taskcluster/.*release.*/taskcluster/.*scriptworker.*/taskcluster/.*signing.*/taskcluster/gecko_taskgraph/actions/.*/taskcluster/gecko_taskgraph/loader/.*dep.py
Thank you!
|
||
Comment 1•2 years ago
|
||
|
Reporter | |
Comment 2•2 years ago
|
||
I think a small error was made here, I see: Affected files matches regexp @/?(.taskcluster.yml|taskcluster/(.attribution.|.balrog.|.beetmover.|.bouncer.|.mar.|.merge_automation.|.notarization.|.openh264.|.partials.|.partner.|.release.|.scriptworker.|.signing.|gecko_taskgraph/action|gecko_taskgraph/loader/.*dep.pys))@
(Note the dep.pys part at the end of the last glob.)
And https://phabricator.services.mozilla.com/D178989 certainly wasn't caught by that glob.
|
|
||
Comment 3•2 years ago
|
||
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #2)
I think a small error was made here, I see: Affected files matches regexp @/?(.taskcluster.yml|taskcluster/(.attribution.|.balrog.|.beetmover.|.bouncer.|.mar.|.merge_automation.|.notarization.|.openh264.|.partials.|.partner.|.release.|.scriptworker.|.signing.|gecko_taskgraph/action|gecko_taskgraph/loader/.*dep.pys))@
(Note the
dep.pyspart at the end of the last glob.)And https://phabricator.services.mozilla.com/D178989 certainly wasn't caught by that glob.
Yeah I set up the rule in correctly and it fixed now. You may need to add the reviewer manually for the current missed ones. And we will see if the next one gets it automatically they way it should.
|
|
Reporter | |
Comment 4•2 years ago
|
||
Sorry, I think there's still a small issue :(. https://phabricator.services.mozilla.com/D179062 wasn't caught by the gecko_taskgraph/action part - presumably because it doesn't have a glob to catch all of the files in that directory.
I think there's also still a trailing s on the gecko_taskgraph/loader part as well.
I think we want the final parts of the regex to be: gecko_taskgraph/action/.*|gecko_taskgraph/loader/.*dep\.py))@
|
|
||
Comment 5•2 years ago
|
||
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)
Sorry, I think there's still a small issue :(. https://phabricator.services.mozilla.com/D179062 wasn't caught by the
gecko_taskgraph/actionpart - presumably because it doesn't have a glob to catch all of the files in that directory.I think there's also still a trailing
son thegecko_taskgraph/loaderpart as well.I think we want the final parts of the regex to be:
gecko_taskgraph/action/.*|gecko_taskgraph/loader/.*dep\.py))@
Sorry for the rule still not working correctly.
I have changed the regex to
@/?(\.taskcluster\.yml|taskcluster/(.*attribution.*|.*balrog.*|.*beetmover.*|.*bouncer.*|.*mar.*|.*merge_automation.*|.*notarization.*|.*openh264.*|.*partials.*|.*partner.*|.*release.*|.*scriptworker.*|.*signing.*|gecko_taskgraph/action|gecko_taskgraph/action/.*|gecko_taskgraph/loader/.*dep\.py))@
|
|
||
Comment 6•2 years ago
|
||
If the regex gets too scary we can also divide it up into more than one Herald rule. May make it more understandable and easier to debug that way. I have done that in a couple of other cases. Reason being is Herald rules only word on AND conditions and not OR.
|
|
Reporter | |
Comment 7•2 years ago
|
||
I think this is all done now.
Description
•