1834554 - Add telemetry to disable PiP interactions

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P1)

Description

[Ania]

With the release of the PiP Disable dialog that allows developers to recommend against using PiP, we need a few changes/additions to the events to understand how the new feature is doing:

1. Recorded when the user opens PiP via a shortcut
   pictureinpicture.opened_method
   object: shortcut

2. Recorded when the user closes PiP via a shortcut
   pictureinpicture.closed_method
   object: shortcut

3. Recorded when the user opens PiP from the URL bar and sees the developer warning dialog
   pictureinpicture.opened_method
   object: urlbar
   extrakey: disableDialog

4. Recorded when Picture-in-Picture is enabled in the Disable PiP Dialog in the url bar (the user disrespects developer warning)
   pictureinpicture.disrespect_disable
   object: urlbar

Comment 1

[Ania]

Attachment: PiP Data Collection Request_Nightly115.txt

Hi!
When you have a chance, would you please take a look at our data collection request for Picture-in-Picture?
We hope to collect this data in Nightly starting from 115, and in Beta and release from 116.

Comment 2

[Chris H-C :chutten]

Comment on attachment 9335476 [details]
PiP Data Collection Request_Nightly115.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Ania Safko is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1834554 - Update PiP telemetry. r=#pip-reviewers

Depends on D175048

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23ec65b0b946
Update PiP telemetry. r=pip-reviewers,kpatenio

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/23ec65b0b946