Open Bug 1834559 Opened 2 years ago Updated 2 days ago

Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

Details

(Keywords: intermittent-failure, regression, test-verify-fail, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file, 1 obsolete file)

Bug 1834559 - Disable browser_history_recently_closed.js on linux 1804 for frequent failures. r=#intermittent-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=416724021&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ed8jn3cERMKFVFJJOZ_lpw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ed8jn3cERMKFVFJJOZ_lpw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

task 2023-05-23T13:59:20.707Z] 13:59:20     INFO - TEST-PASS | browser/components/customizableui/test/browser_history_recently_closed.js | Opened 'Recently closed windows' panel - 
[task 2023-05-23T13:59:20.708Z] 13:59:20     INFO - Buffered messages finished
[task 2023-05-23T13:59:20.708Z] 13:59:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_recently_closed.js | Opened correct URL - Got "about:blank", expected "https://example.com/"
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - Stack trace:
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/browser-test.js:test_is:1610
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_history_recently_closed.js:testRecentlyClosedWindows:190
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/browser-test.js:handleTask:1133
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1205
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1347
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1116
[task 2023-05-23T13:59:20.709Z] 13:59:20     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
Keywords: regression
Regressed by: 833037
Summary: Intermittent TV browser/components/customizableui/test/browser_history_recently_closed.js | Opened correct URL - Got "about:blank", expected "https://example.com/" → Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | Opened correct URL - Got "about:blank", expected "https://example.com/"
Summary: Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | Opened correct URL - Got "about:blank", expected "https://example.com/" → Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug
Attachment #9381504 - Attachment is obsolete: true

Hi Stephen! Your push caused a spike in fails for this bug, as it can be seen here , could you please take a look? Thanks!

Flags: needinfo?(sthompson)
Summary: Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug → Frequent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug

Taking a look

See Also: → 1933623

Looks like the test I added has nondeterministic behavior. I'm closing a tab group with two tabs in it and then using a menu to open the "first" closed tab, but it looks like either one could be chosen.

I fixed that in bug 1933623, so I'm expecting the failure rate to decrease

Flags: needinfo?(sthompson)
Whiteboard: [stockwell disable-recommended]
Summary: Frequent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug → Intermittent browser/components/customizableui/test/browser_history_recently_closed.js | single tracking bug
Whiteboard: [stockwell disable-recommended]
Assignee: nobody → agoloman
Status: NEW → ASSIGNED
Assignee: agoloman → nobody
Status: ASSIGNED → NEW
Keywords: leave-open
Pushed by agoloman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41b7588e99ef Disable browser_history_recently_closed.js on linux 1804 for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Whiteboard: [stockwell disable-recommended] → [stockwell disable]
Whiteboard: [stockwell disable] → [stockwell disabled]
No longer regressed by: 833037

Hi, Jeremy! Your push caused this bug to be more frequent. Could you take a look?

Flags: needinfo?(jswinarton)

Backed out the disable patch for causing bc failures @browser_history_recently_closed_middleclick.js.

Keywords: leave-open
Whiteboard: [stockwell disabled]
See Also: → 1947098

Gijs, could you please over this bug or maybe redirect? The frequent failure here is this one, it fails, times out and then crashes: https://treeherder.mozilla.org/logviewer?job_id=496006072&repo=autoland&lineNumber=6191
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_recently_closed.js | Closed tab from the second window is opened - "about:mozilla" == "about:robots" -

There's also Bug 1947098 that tracks the same test but failing on a11y: https://treeherder.mozilla.org/logviewer?job_id=496100998&repo=autoland&lineNumber=3567
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_recently_closed.js | Node is not accessible via accessibility API: id: , tagName: toolbarbutton, className: subviewbutton subviewbutton-iconic bookmark-item

We've tried disabling it but it lead to these kind of failures.

Flags: needinfo?(gijskruitbosch+bugs)

Thanks for the ping, Cosmin! The vast majority (120) of failures here is to do with the a11y checks case.

Disabling both this and browser_history_recently_closed_middleclick.js for the a11y check jobs seems like a straightforward way to stop most of the bleeding for now.

The a11y failure is new and tracked in bug 1947098, regressed by bug 1944416. The problem there looks like it might be quite simple to fix: the test tries to click a button inside a group without ever showing that group, and so the a11y test complains that we never bothered to create an a11y node for the (invisible) item. The test should show the subview containing the button it wants by clicking the group and using await BrowserTestUtils.waitForEvent(subview, "ViewShown") or similar.

I can't quickly reproduce the debug failure here or the middle click failure; maybe they need a Linux VM? Though I do see that the closed tabs list in the recently_closed_middleclick.js case gets bigger and bigger when running with --verify, so it does look like that test needs some work in the cleanup department, which may be enough to fix the issue.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to :Gijs (he/him) from comment #74)

Thanks for the ping, Cosmin! The vast majority (120) of failures here is to do with the a11y checks case.

Disabling both this and browser_history_recently_closed_middleclick.js for the a11y check jobs seems like a straightforward way to stop most of the bleeding for now.

The a11y failure is new and tracked in bug 1947098, regressed by bug 1944416. The problem there looks like it might be quite simple to fix: the test tries to click a button inside a group without ever showing that group, and so the a11y test complains that we never bothered to create an a11y node for the (invisible) item. The test should show the subview containing the button it wants by clicking the group and using await BrowserTestUtils.waitForEvent(subview, "ViewShown") or similar.

confirming the bug seems to be fix-able and I would highly discourage from disabling the a11y checks to avoid risking introducing an accessibility blocker now or in the future.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: