1834612 - Permit DirectComposition on Windows 11 regardless of monitor refresh rates

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ray Kraesig [:rkraesig]]

Bug 1704954 disabled WebRender for users with NVIDIA graphics hardware and mixed monitor refresh rates on Windows 10 and 11, as a mitigation for bug 1638709. However, that bug appears not to occur on Windows 11 [*], and the fallback path it uses has been shown to cause issues there (bug 1763981).

Restrict the mitigation to only occur on Windows 10, where bug 1638709 is exhibited, but where no issues with the fallback path are known. (If problems do arise on Windows 11, users can still disable DirectComposition via gfx.webrender.dcomp.enabled = false.)

This will also effectively revert bug 1816001, which it obviates.

[*] Well, hardly ever. See bug 1638709 comment 181 for details.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1834612 - [1/1] Restrict DComp-disabling mitigation to Windows 10 r?#gfx-reviewers!,ahale

Bug 1704954 disabled DirectComposition for users with NVIDIA graphics
hardware and mixed monitor refresh rates on Windows 10 and 11, as a
mitigation for bug 1638709. However, that bug is almost -- perhaps
entirely -- unknown on Windows 11 (q.v. for details), and the fallback
path it uses has been shown to cause issues there (bug 1763981).

Restrict the mitigation to only occur on Windows 10, where bug 1638709
is exhibited, but where no issues with the fallback path are known.

This also effectively reverts bug 1816001, which it obviates.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55a239852ac8
[1/1] Restrict DComp-disabling mitigation to Windows 10  r=ahale,gfx-reviewers

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/55a239852ac8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rkraesig, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Ray Kraesig [:rkraesig]]

Not this late in the beta cycle. Especially since v114 has a separate mitigation for 1763981.