WPT test css/css-masking/parsing/mask-valid.sub.html fails in Firefox due to serialization issues
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: dholbert, Assigned: boris)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We fail this WPT test:
http://wpt.live/css/css-masking/parsing/mask-valid.sub.html
It's testing the mask shorthand property.
Our subtest failures break down into a few different categories:
(1) A whole bunch of failures where we seem to be unnecessarily serializing mask-image:none as part of the specified style. e.g. here:
data:text/html,<body style="mask: repeat-y"><script>alert(document.body.style.mask)</script>
(2) A failure where the test is expecting mask:margin-box to be accepted but we reject it, since that's a value that was removed from the spec per bug 1823257 comment 2. (This part is a test bug.)
(3) Some cases where we serialize mask-position with more values than the test is expecting. (This one is related to but possibly distinct from bug 1823479.)
|
Reporter | |
Updated•1 year ago
|
|
||
Comment 1•1 year ago
•
|
||
We are likewise failing https://wpt.fyi/results/css/css-backgrounds/parsing/background-valid.html. Should we file a new bug for that? Safari 17 should have fixes for both of these, as implemented in this commit
|
|
Reporter | |
Comment 2•11 months ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
(2) A failure where the test is expecting
mask:margin-boxto be accepted but we reject it, since that's a value that was removed from the spec per bug 1823257 comment 2. (This part is a test bug.)
This is being addressed in https://github.com/web-platform-tests/interop/issues/387 FWIW.
|
Assignee | |
Comment 3•9 months ago
|
||
- We should omit
mask-imageif it is the initial value and there are
any other properties which are not initial values. - Tweak the order of
<masking-mode>, which should be the last one per spec.
|
||
Updated•9 months ago
|
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/081d116d10f8 Fix the serialization of mask shorthand property. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42181 for changes under testing/web-platform/tests
|
||
Comment 6•9 months ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
|
|
||
Comment 8•9 months ago
•
|
||
:boris, we seem to still be failing some tests here (or at least I still see them failing on the latest MacOS nightly on http://wpt.live/css/css-masking/parsing/mask-valid.sub.html). We're also failing some tests related to initial values (https://wpt.fyi/results/css/css-masking/inheritance.sub.html).. shall we reopen this bug, or are the failures related to https://bugzilla.mozilla.org/show_bug.cgi?id=877294?
|
|
Assignee | |
Comment 9•9 months ago
|
||
(In reply to Thomas Wisniewski [:twisniewski] from comment #8)
:boris, we seem to still be failing some tests here (or at least I still see them failing on the latest MacOS nightly on http://wpt.live/css/css-masking/parsing/mask-valid.sub.html). We're also failing some tests related to initial values (https://wpt.fyi/results/css/css-masking/inheritance.sub.html).
I suspect http://wpt.live/css/css-masking/parsing/mask-valid.sub.html is a little bit out-of-date. I fixed this bug based on the wpt.fyi: https://wpt.fyi/results/css/css-masking/parsing/mask-valid.sub.html?label=experimental&label=master&aligned. All the current failures are related mask-border-* properties.
or are the failures related to https://bugzilla.mozilla.org/show_bug.cgi?id=877294?
Yes. Per wpt.fyi, the current failures are related https://bugzilla.mozilla.org/show_bug.cgi?id=877294, i.e. mask-border-* related properties.
I'd prefer not to reopen this bug. Just link these failures to https://bugzilla.mozilla.org/show_bug.cgi?id=877294.
Description
•