1834665 - Use "step-end" easing in two-clip-path-animation-diff-length* WPT tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Daniel Holbert [:dholbert]]

Per review suggestion:
https://phabricator.services.mozilla.com/D178876#5901710

The two-clip-path-animation-diff-length* WPTs have animations that are expected to be sampled near the start of the animation where we assume the value is still close-enough to its initial value to be indistinguishable from that state.

If the snapshot is a little bit later than expected, it might sample a fractional pixel value for that property and spuriously fail the test.

As hiro notes, we can use step-end easing to avoid that problem.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1834665: Use "step-end" animation easing function in two-clip-path-animation-diff-length* WPTs. r?hiro

Also, increase the length of a fairly-short animation in
two-clip-path-animation-diff-length3.html from 2s to 20s, to avoid intermittent
failures. The test is assuming that the snapshot will happen while the
animation is playing, but the reftest-snapshot isn't guaranteed to be
instantaneous, and under certain configurations, it might be delayed a little
bit and get taken after the 2-second animation has finished playing.

Depends on D178876

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36068bff4056
Use "step-end" animation easing function in two-clip-path-animation-diff-length* WPTs. r=hiro

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Daniel Holbert [:dholbert]]

CC @jgraham - would you mind helping with comment 3?

(This patch landed as part of a stack, with bug 1834651 (earlier in the stack) making a change to the same line, which this layered on top of. Maybe that resulted in the bot thinking they were two independent changes and producing a merge conflict?)

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36068bff4056

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40213 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot