Closed
Bug 1834699
Opened 2 years ago
Closed 2 years ago
HTTP3_CONNECTION_CLOSE_3 may record unexpected value
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: valentin, Assigned: dotoole, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
Bug 1834699 - Changed CloseError::Tag::EchRetry telemetry value to align with bucket size. r=kershaw
48 bytes,
text/x-phabricator-request
|
Details | Review |
I was looking at our telemetry recently and it stood out that HTTP3_CONNECTION_CLOSE_3 records values between 0-100, but here we record 121 for CloseError::Tag::EchRetry
We should add a DIAGNOSTIC_ASSERT that the recorded value is <=100, and fixup this one to map to a sensible value.
These notes might be helpful regarding DIAGNOSTIC_ASSERT:
https://searchfox.org/mozilla-central/rev/a4fd6daad3a4123d995478467c1274653b283801/mfbt/Assertions.h#326-335
|
||
Comment 3•2 years ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:dotoole, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(kershaw)
Flags: needinfo?(dotoole)
|
||
Updated•2 years ago
|
Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32ef0ac1a171
Changed CloseError::Tag::EchRetry telemetry value to align with bucket size. r=kershaw,necko-reviewers
|
Reporter | |
Updated•2 years ago
|
Flags: needinfo?(dotoole)
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•