1834921 - ipc/glue/GeckoChildProcessHost.cpp:378:8: error: expected value in expression

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Mike Hommey [:glandium]]

Building with --target=aarch64-apple-ios fails with (among many other things):

 1:05.37 /tmp/gecko/ipc/glue/GeckoChildProcessHost.cpp:378:8: error: expected value in expression
 1:05.37 #  elif
 1:05.37        ^

The real intent here is actually to hit the #error on the line that follows: # error "Unknown platform"

The code for mach port-based process launcher is bound to a mix of XP_MACOSX and MOZ_WIDGET_COCOA. Some if not all of it could probably be behind XP_DARWIN.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jld, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The “fix” here is just s/elif/else/, so that we break the build intentionally as expected, instead of accidentally. I'm not sure if this bug is meant to cover just that or the larger task of making this code build on iOS.

Comment 3

[Mike Hommey [:glandium]]

The latter. But fixing the former would be nice (possibly in a separate bug)

Comment 4

[Mike Hommey [:glandium]]

Note that the cedar branch has a patch for this.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1834921 - Add a stub ProcessLauncher for iOS.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fc878e1562c
Add a stub ProcessLauncher for iOS. r=ipc-reviewers,nika

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9fc878e1562c