1834934 - dom/media/platforms/apple/AppleDecoderModule.cpp:217:7: error: 'VTRegisterSupplementalVideoDecoderIfAvailable' is unavailable: not available on iOS

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Mike Hommey [:glandium]]

Building with --target=aarch64-apple-ios fails with (among many other things):

 0:03.53 In file included from Unified_cpp_dom_media_platforms1.cpp:11:
 0:03.53 /tmp/gecko/dom/media/platforms/apple/AppleDecoderModule.cpp:217:7: error: 'VTRegisterSupplementalVideoDecoderIfAvailable' is unavailable: not available on iOS
 0:03.53       VTRegisterSupplementalVideoDecoderIfAvailable(kCMVideoCodecType_VP9);
 0:03.53       ^
 0:03.53 /tmp/gecko/iPhoneOS16.4.sdk/System/Library/Frameworks/VideoToolbox.framework/Headers/VTUtilities.h:60:16: note: 'VTRegisterSupplementalVideoDecoderIfAvailable' has been explicitly marked unavailable here
 0:03.53 VT_EXPORT void VTRegisterSupplementalVideoDecoderIfAvailable( CMVideoCodecType codecType ) API_AVAILABLE(macosx(11.0)) API_UNAVAILABLE(ios, watchos, tvos);
 0:03.53                ^
 0:03.58 In file included from Unified_cpp_dom_media_platforms1.cpp:29:
 0:03.58 /tmp/gecko/dom/media/platforms/apple/AppleVTDecoder.cpp:10:10: fatal error: 'IOSurface/IOSurface.h' file not found
 0:03.58 #include <IOSurface/IOSurface.h>
 0:03.58          ^~~~~~~~~~~~~~~~~~~~~~~
 0:03.58 /tmp/gecko/dom/media/platforms/apple/AppleVTDecoder.cpp:10:10: note: did not find header 'IOSurface.h' in framework 'IOSurface' (loaded from '/tmp/gecko/iPhoneOS16.4.sdk/System/Library/Frameworks')

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1834934 - Only implement AppleDecoderModule::RegisterSupplementalVP9Decoder on macOS.

VTRegisterSupplementalVideoDecoderIfAvailable is not available on iOS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fba162c47a9
Only implement AppleDecoderModule::RegisterSupplementalVP9Decoder on macOS. r=media-playback-reviewers,padenot

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4fba162c47a9