1834995 - Firefox add-on suggestion is not correctly displayed in RTL builds

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: add-on suggestion RTL display

Found in

• Fx 115.0a1

Affected versions

• Fx 115.0a1

Affected platforms

• Windows 10
• macOS
• Ubuntu 20

Preconditions
browser.urlbar.addons.featureGate set to true
browser.urlbar.suggest.addons set to true
browser.urlbar.quicksuggest.enabled set to true
browser.urlbar.suggest.quicksuggest.nonsponsored set to true
browser.urlbar.quicksuggest.dataCollection.enabled set to true
browser.urlbar.merino.enabled set to true
browser.urlbar.merino.providers set to amo
browser.urlbar.bestMatch.enabled set to true

Use an RTL build locale like: ar, he.

Steps to reproduce

1. Launch Firefox.
2. In the URL bar, input a keyword of an add-on suggestion (e.g. typo, darker, video dl)

Expected result

• All elements of the add-on suggestion are correctly displayed in RTL.

Actual result

• Last character for the first 2 lines is not displayed in it's correct spot (e.g. '/' which is the last character for the URL is displayed at the begining of the title)
• Last review star orientation is not correct. If it's 1/2 of a star, the empty half of the star should be on the left side of the star, not the right side.

Regression range

• Not a regression

Additional notes

• Please see the attachment for more details.
• The issue occurs regardless of the section where the add-on suggestion is displayed (top pick or firefox suggest)

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1834995: Use -moz-locale-dir for rating star for RTL because of XUL document

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1834995: Change the component order for RTL to the opposite

Depends on D179314

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2023-05-29 at 8.34.05.png

Hi Cristian! Thank you very much for the report.

I could reproduce and fix the following issues:

1. Position of slash. This problem is not only the slash position, but we should change the component order as well to the opposite. https://phabricator.services.mozilla.com/D179315
2. Rating star. https://phabricator.services.mozilla.com/D179314

However, the dot position of the description field might not be an issue (I'm not familiar with RTL..), or a bug belongs to another component at least, not AddonSuggestions. I attach a screenshot of about:addons, the dot position is located at the beginning. Could you confirm that one?

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Hello Daisuke,
Yes, I can confirm that the dot is positioned in the beggining of the add-on description in about:addons. Waiting for the patch for the other 2 fixes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75eec6e58a8e
Use -moz-locale-dir for rating star for RTL because of XUL document r=adw
https://hg.mozilla.org/integration/autoland/rev/40997d8c121e
Change the component order for RTL to the opposite r=adw

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/75eec6e58a8e
https://hg.mozilla.org/mozilla-central/rev/40997d8c121e