1835020 - Apply Quarantine logic to DNR filters

Status: NEW

(WebExtensions :: Request Handling, defect, P2)

Description

[Tomislav Jovanovic :zombie]

From https://phabricator.services.mozilla.com/D178597#5906316.

Splitting out from https://phabricator.services.mozilla.com/D178597#5906316 to avoid doing a full build every time I need to update one of the js patches on top of it.

Comment 1

[Rob Wu [:robwu]]

To save a click, pasting the relevant bit from the referenced review:

DNR doesn’t go through canAccess because it is independent of host permissions by design, so you need to add a check for QD in the following places:

• https://searchfox.org/mozilla-central/rev/4fc60ae5a878dfa8cb78153ed994f4d377f44dd1/toolkit/components/extensions/ExtensionDNR.sys.mjs#1920 (startDNREvaluation)
• https://searchfox.org/mozilla-central/rev/4fc60ae5a878dfa8cb78153ed994f4d377f44dd1/toolkit/components/extensions/ExtensionDNR.sys.mjs#2237 (testMatchOutcome implementation)

And a unit test (see restrictedDomains for example) at https://searchfox.org/mozilla-central/rev/4fc60ae5a878dfa8cb78153ed994f4d377f44dd1/toolkit/components/extensions/test/xpcshell/test_ext_dnr_system_restrictions.js

Comment 2

[William Durand [:willdurand]]

See also: https://phabricator.services.mozilla.com/D179388#inline-994201

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Request Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.