183505 - XUL fastload messes up loading stylesheets

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Boris Zbarsky [:bzbarsky]]

When fastloading a document, we load stylesheets via AddPrototypeSheets() from
nsXULDocument::ResumeWalk().  This uses LoadAgentSheet which messes up some
things (like setting the right ownerNode on the sheet, using the right charset,
etc).

If the only issue is that we need sync loading, perhaps a sync version of
LoadStyleLink would be more appropriate here?

Comment 1

[Brendan Eich [:brendan]]

I'm ducking, ben's catching.

/be

Comment 2

[Nickolay_Ponomarev]

This depends on bug 319654, since the owner node should be the PI that referenced the stylesheet (in case the stylesheet is loaded because of a PI).

What about style overlays from the chrome registry? Is there a better way to load them than what we do now?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Don't know much about style overlays, sorry... :(

Comment 4

[Nickolay_Ponomarev]

bz explained on IRC that his concern was about stylesheets loaded from processing instructions - they were loaded differently in the fastload case than in normal one. In case of chrome registry style overlays we can't do anything better, as there's no node or charset to use.

Comment 5

[Nickolay_Ponomarev]

Should be fixed by the patch in bug 319654.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, verified.