Closed Bug 1835066 Opened 7 months ago Closed 6 months ago

[css-nesting] Enable on Nightly


(Core :: CSS Parsing and Computation, task)




115 Branch
Tracking Status
firefox115 --- fixed


(Reporter: emilio, Assigned: emilio)



(Keywords: dev-doc-complete)


(5 files)

No description provided.

Even though there's some implementation work left before it being in a
shippable state, the bits that do work (which is quite a few) should
work reliably and performantly.

Given this is (afaict) the first implementation of the new spec, I want
to let people test it easier, specially since there are some questions
about error recovery that nesting could change.

Without nesting, the parser error is the unexpected token error, emitted
from cssparser.

With nesting enabled these behave the same as other strings outside of a
block (so an "unexpected end of input" error instead).

Tweak the test a bit to keep testing what this test wants to test (that
unexpected token errors are escaped).

Pushed by
Remove now-valid selector from file_bug416317.xhtml. r=dholbert
Keywords: leave-open
Attachment #9336994 - Attachment description: WIP: Bug 1835066 - Make our nesting implementation match the new spec better. → Bug 1835066 - Make our nesting implementation match the new spec better. r=tlouw,#style,#layout
Pushed by
Tweak test_parser_diagnostics_unprintables.html to keep testing unexpected token errors. r=dholbert
Pushed by
Remove some WPTs which aren't valid in presence of nesting. r=dholbert
Make our nesting implementation match the new spec better. r=tlouw
[css-nesting] Enable on nightly. r=dholbert
Created web-platform-tests PR for changes under testing/web-platform/tests
Pushed by
Fix a Gecko reftest that isn't valid when nesting is enabled.
Regressions: 1836670
Pushed by
Disable a test on opt builds for now.
Keywords: leave-open
Regressions: 1836745
Upstream PR merged by moz-wptsync-bot

A number of pages have been created:

  • /en-US/docs/Web/CSS/CSS_nesting
  • /en-US/docs/Web/CSS/Nesting_selector
  • /en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
  • /en-US/docs/Web/CSS/CSS_nesting/Nesting_and_specificity
  • /en-US/docs/Web/CSS/CSS_nesting/Nesting_at-rules

Added to the release notes for Firefox 117:

  • /en-US/docs/Mozilla/Firefox/Releases/117

Updated the CSSRef.ejs page in Yari to show the new pages in Guides

Associated Pull Requests

You need to log in before you can comment on or make changes to this bug.