1835066 - [css-nesting] Enable on Nightly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1835066 - [css-nesting] Enable on nightly. r=dholbert,#style

Even though there's some implementation work left before it being in a
shippable state, the bits that do work (which is quite a few) should
work reliably and performantly.

Given this is (afaict) the first implementation of the new spec, I want
to let people test it easier, specially since there are some questions
about error recovery that nesting could change.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1835066 - Remove now-valid selector from file_bug416317.xhtml. r=dholbert,#layout,#style

Depends on D179271

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1835066 - Remove some WPTs which aren't valid in presence of nesting. r=#style,#layout

Depends on D179685

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1835066 - Make our nesting implementation match the new spec better. r=tlouw,#style,#layout

Depends on D179686

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1835066 - Tweak test_parser_diagnostics_unprintables.html to keep testing unexpected token errors. r=#style,#layout

Without nesting, the parser error is the unexpected token error, emitted
from cssparser.

With nesting enabled these behave the same as other strings outside of a
block (so an "unexpected end of input" error instead).

Tweak the test a bit to keep testing what this test wants to test (that
unexpected token errors are escaped).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cae8c946ae5
Remove now-valid selector from file_bug416317.xhtml. r=dholbert

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7cae8c946ae5

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c8f755bb185
Tweak test_parser_diagnostics_unprintables.html to keep testing unexpected token errors. r=dholbert

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af7ff8bcf986
Remove some WPTs which aren't valid in presence of nesting. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6d74219ed171
Make our nesting implementation match the new spec better. r=tlouw
https://hg.mozilla.org/integration/autoland/rev/96604e3a217e
[css-nesting] Enable on nightly. r=dholbert

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40376 for changes under testing/web-platform/tests

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00802389f336
Fix a Gecko reftest that isn't valid when nesting is enabled.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81afd61afe48
Disable a test on opt builds for now.

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7c8f755bb185
https://hg.mozilla.org/mozilla-central/rev/af7ff8bcf986
https://hg.mozilla.org/mozilla-central/rev/6d74219ed171
https://hg.mozilla.org/mozilla-central/rev/96604e3a217e
https://hg.mozilla.org/mozilla-central/rev/00802389f336
https://hg.mozilla.org/mozilla-central/rev/81afd61afe48

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Sebastian Zartner [:sebo]]

This should be documented at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features.

Sebastian

Comment 16

[Dave Letorey]

A number of pages have been created:

• /en-US/docs/Web/CSS/CSS_nesting
• /en-US/docs/Web/CSS/Nesting_selector
• /en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
• /en-US/docs/Web/CSS/CSS_nesting/Nesting_and_specificity
• /en-US/docs/Web/CSS/CSS_nesting/Nesting_at-rules

Added to the release notes for Firefox 117:

• /en-US/docs/Mozilla/Firefox/Releases/117

Updated the CSSRef.ejs page in Yari to show the new pages in Guides

Associated Pull Requests

• Content PR
• Browser Compat Data PR
• Yari PR