Closed
Bug 1835123
Opened 2 years ago
Closed 14 days ago
[Tabs Tray interactor Refactor] Remove `TabsTrayController.handleTabUnselected`
Categories
(Firefox for Android :: Tabs, task, P3)
Tracking
()
RESOLVED
FIXED
142 Branch
Tracking | Status | |
---|---|---|
firefox142 | --- | fixed |
People
(Reporter: 007, Assigned: calu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group4])
Attachments
(1 file)
After the XML version is removed, TabsTrayController.handleTabUnselected
can be removed as this is only used for the XML's tab reordering functionality.
As part of this ticket:
- Remove the interactor call,
onTabUnselected
- Remove the controller function
handleTabUnselected
- Add the
TabsTrayAction.RemoveSelectTab
dispatch tohandleTabSelected
, the function that handles tab clicks.
Assignee | ||
Updated•10 months ago
|
Whiteboard: [fxdroid] [group4]
Updated•10 months ago
|
Assignee | ||
Updated•14 days ago
|
Assignee: nobody → calu
Assignee | ||
Comment 1•14 days ago
|
||
Pushed by calu@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/d15ec7f1ff18
https://hg.mozilla.org/integration/autoland/rev/2b94be3ab051
Handle unselecting tabs through handleTabSelected r=android-reviewers,007
Status: NEW → RESOLVED
Closed: 14 days ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•