1835151 - Do not increment an error on an empty event context in TF glean

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Perry McManis [:perry.mcmanis]]

So, it turns out that the way that we're being fed empty event contexts is incrementing the error on that field in a way we did not expect.

We should do a couple of checks to make sure this field isn't empty from a human perspective, because we're getting more JSON parse errors than we potentially expected.

Comment 1

[Chris H-C :chutten]

Note that we'll still get a lot of errors for event_context values that are valid, but aren't valid JSON (values like "whats-new-panel" which is a bare string, not a JSON-encoded string (which would be "\"whats-new-panel\"")). This count of parser errors will still be weak evidence that anything's gone wrong with the data.

Comment 2

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1835151 - Do not increment an error on an empty event context in glean r?dmose

Comment 3

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1835151 - Improve the usefullness of Event Context Parse Errors in glean r?dmose

Here is a potential improvement to handling of event_context parse
errors.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ed2e01cccb
Improve the usefullness of Event Context Parse Errors in glean r=omc-reviewers,aminomancer

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/83ed2e01cccb